571486 - attachment keyword detection false positive, http/https link handling incorrect

Status: RESOLVED DUPLICATE of bug 880261

(Thunderbird :: Message Compose Window, defect)

Description

[Paolo Bonzini]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.3) Gecko/20100403 Fedora/3.6.3-4.fc13 Firefox/3.6.3
Build Identifier: 

Pasting a link to a bugzilla attachment triggers the attachment keyword detection, because the link includes "attachment.cgi"

Reproducible: Always

Steps to Reproduce:
1. Paste "https://bugzilla.example.com/attachment.cgi?id=423248" into an email.

Actual Results:  
The attachment keyword detector asks me if I want to attach something.

Expected Results:  
Attachment keyword in URLs should not trigger the attachment keyword detector.

Comment 1

[Paolo Bonzini]

There is code to do this:

http://mxr.mozilla.org/comm-central/source/mail/base/modules/attachmentChecker.js#67

94     var matching = re.exec(mailData);
95     // Ignore the match if it was a URL.
96     if (matching && !(/^http|^ftp/i.test(matching[0])))
97       // We're not worried about matching too much because we only add the
98       // keyword to the list of found keywords.
99       keywordsFound.push(keywordsArray[i]);
100   }

but it's broken because matching[0] will only contain the word "attachment".

Comment 2

[rsx11m]

Confirmed with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.4) Gecko/20100608 Thunderbird/3.1 (RC2) as well. Didn't find anything filed yet.

Comment 4

[Thomas D. (:thomas8)]

This case (ignoring any attachment keyword if inside URL) was fixed in Bug 880261.