571502 - when replying to a non-format=flowed message, conversion to f=f mangles spacing in the middle of a line

Status: RESOLVED DUPLICATE of bug 448198

(Thunderbird :: Message Compose Window, defect)

Description

[Paolo Bonzini]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.3) Gecko/20100403 Fedora/3.6.3-4.fc13 Firefox/3.6.3
Build Identifier: 

When I reply to a message that includes code, the spacing around several characters (including < > &) is changed incorrectly while quoting the message.

The same behavior doesn't happen if I use the "Paste as Quote" menu item.

Reproducible: Always

Steps to Reproduce:
1. Save the attachment to a file
2. Open it using File/Open/Message
3. Notice it says "version_id >= 11"
4. Click "reply"
Actual Results:  
The first line in the reply will be:

> +	if (version_id>= 11) {

without a space before the greater-than sign.

Expected Results:  
Spacing should be kept as it was.

A possible workaround could be to copy the text before hitting reply and do Select All/Paste As Quote (Ctrl-A/Ctrl-Shift-O) after.  This way the quotations are not mangled.  However, this is unacceptable in general, as it removes the "On ..., XYZ wrote:" line from the message.

I'm marking it as major because it occurs many times a day when working on projects that use email and mailing lists for code reviews.

Comment 1

[Paolo Bonzini]

Attachment: minimal testcase

Comment 2

[Paolo Bonzini]

BTW, it is not restricted to message/rfc822 files, it's just a handy testcase.

Comment 3

[[:Aureliano Buendía]]

Paolo what you think about bug #534068? Could be basically this a duplicate of him (even if you do you mean "reply")?

Comment 4

[Paolo Bonzini]

Attachment: adding f=f hides the bug

It is somewhat related to format=flowed:

1) setting mailnews.send_plaintext_flowed to false is a workaround for this bug.

2) the bug only occurs if the message is _not_ in format=flowed.  This second attachment is the same as bug.eml, but has f=f encoding and is not mangled.

However no, it's not the same.  In this bug, the problem occurs already when the message is quoted in the compose window, not when they are sent.  The compose window shows exactly what will be sent, and it is wrong.  If you fix it in the window it will be sent correctly.

It appears that this bug is due to excessive zeal in converting non-format=flowed messages to f=f.  I'll change the subject accordingly.

Comment 5

[[:Aureliano Buendía]]

(In reply to comment #4)
> Created an attachment (id=454848) [details]
> adding f=f hides the bug
> 
> It is somewhat related to format=flowed:
...then could be a dupe of bug #204478 ? Paolo your thoughts ? ;-)

Comment 6

[Paolo Bonzini]

No, I _do_ want to send f=f even though I'm replying to non-f=f.

Comment 7

[Paolo Bonzini]

Still fails in Thunderbird 5.0.  Can anybody confirm this?

Comment 8

[Matěj Cepl]

Discussion on http://groups.google.com/group/mozilla.dev.apps.thunderbird/browse_thread/thread/1ba805b10a6369c1# might be relevant for this bug.

Comment 9

[Paolo Bonzini]

Still fails in 10.0.