571596 - chowse stars

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect)

Description

[Jeff Balogh (:jbalogh)]

In mocks chowse uses shiny yellow stars: https://bug557879.bugzilla.mozilla.org/attachment.cgi?id=449642

amo's actual stars are orange and drab: https://addons.mozilla.org/media/img/amo2009/icons/stars.png

Let's use chowse stars!

Comment 1

[Justin Scott [:fligtar]]

If this is a simple change, it's fine. If it will take more than 10 minutes, I think it should go to Future.

Comment 2

[Chris Howse [:chowse]]

Here's are some drop-in replacements:

24-bit PNG, using semi-translucent color for the unselected stars:
http://people.mozilla.com/~chowse/drop/amo/reviews/stars.png

8-bit PNG, with a solid gray for unselected stars:
http://people.mozilla.com/~chowse/drop/amo/reviews/stars-noalpha.png

Let me know if you can swap this in quickly: I'd like to see these stars in-place to make sure the colors aren't too faint.

Comment 3

[Jeff Balogh (:jbalogh)]

stars-noalpha: http://grab.by/4TrT http://grab.by/4TrX
stars-alpha:  http://grab.by/4Ts2 http://grab.by/4Ts3

The alpha looks much better against the blue background.  They are kinda faint, but they get the point across without being too noisy.  I'm happy with stars.png if you are.

Comment 4

[Chris Howse [:chowse]]

Thanks for the dry run. I definitely prefer stars-alpha. As long as IE6 compatibility isn't an issue, I say go with it.

I also made a few tweaks and reuploaded
http://people.mozilla.com/~chowse/drop/amo/reviews/stars.png
The empty stars have a little more contrast, but still less than the original stars. I also moved all the stars 1 pixel to the left, since they appear to be getting truncated on the right in your screen shots. If you need me to change it back (say, if left-shifting the background image causes more truncation), let me know.

Comment 5

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commits/dbb740b

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; I'm star-struck! </drumhit>