57165 - Document/Message is not spellchecked if the caret is at the end of the document

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[marina]

**** observed with 2000-10-18 build ****
Steps to reproduce:
- set your option to spell check before sending mail;
- compose mail and click Send (you'll see spell checker coming up and checking);
- copy some text from the browser and paste it into the composition widow;
- click Send;
//note: no spell check window appears (i experimented with mispelled words, they 
are ignored as well)

Comment 1

[Jean-Francois Ducarroz]

reassign to kin

Comment 2

[kinmoz]

Looks like the editor code that initializes the spellchecker is hard coded to
say start spellchecking from the current text block where the caret is, to the
end of the document. That is, it does not spellcheck from the beginning of the
document/message.

The problem is not that the spellchecker doesn't check pasted text, it's that
the caret may have ended up on a blank line at the end of the document after you
pasted all your text.

This is bad and may cause messages in mail to be sent without actually checking
the entire document.

Changed the summary from "No spell checking is done for the pasted text" to
"Document/Message is not spellchecked if the caret is at the end of the document.

Nominating for rtm. There is a trivial fix that will make the spellchecker
always start from the beginning of the document/message, like it did in 4.x.
It's a matter of changing a PR_FALSE, to a PR_TRUE when initializing the
spellchecker. I'll attatch a patch shortly.

Comment 3

[kinmoz]

Attachment: Patch for easiest workaround.

Comment 4

[kinmoz]

I should also mention that the proper fix for this would be to modify the editor
idl interfaces to allow JS to control where the spellchecker starts checking,
but that may require too many changes for PDT to consider this fix for RTM.

Comment 5

[rubydoo123]

and here I thought the spell-checker was broken, I could not figure out why my
mail would go out with obvious misspellings. It is not intuitive at all to know
to 'click' to the beginning of the note, especially if the user ahs auto-check
on send.

Comment 6

[kinmoz]

Cc [e-mail] for review, and [e-mail] for super review.

Comment 7

[Simon Fraser [no longer active]]

sr=sfraser

Comment 8

[Kathleen :Brade]

r=brade

Comment 9

[selmer (gone)]

rtm++

Comment 10

[kinmoz]

Fix checked into the trunk:

    mozilla/editor/base/nsEditorShell.cpp   revision 1.211

Fix checked into the Netscape_20000922_BRANCH:

    mozilla/editor/base/nsEditorShell.cpp    revision 1.202.2.8

Comment 11

[fenella]

Using Linux (2000-10-20-09 MN6)
Win32 (2000-10-20-09 MN6)
Mac (2000-10-20-08 MN6)
Peter, I follow your scenario up to Step 2. When I want to close the Spell
Checker using Cancel of Xclose window, both the Spell Checker and Compose window
go away. This means I cannot go onto step 3 to copy and paste. 
In Nova, it has the stop button, but in seamonkey, there is NO Stop button for
me just to close the Spell Checker. 

Please advise..

Comment 12

[laurel]

OK using oct20 mn6 commercial branch build Win98, linux rh6.0.
Still need to check mac ....

Comment 13

[laurel]

OK mac branch commercial build oct20, using OS 9.0
OK modern and classic skins.

Comment 14

[laurel]

OK using feb19 commercial trunk builds, linux rh6.0, win98 and mac OS 9.0