571733 - Session restore when Process has to be terminated from task manager should obey user homepage choice if selected not restore tabs that forced using Task Manager to kill process for the initial blank tab

Status: VERIFIED INVALID

(Firefox :: Session Restore, defect)

Description

[Dale Fiero]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3

If a security issue or web page hangs up Firefox and the only way to safely exit the situation is by killing the Firefox process when Firefox is restarted the startup option should be respected. If the option is set to "Show my Homepage" that is what should happen not restoring the tabs and website that forced the killing of the Firefox process. If the option is set to "Show my windows and tabs from last time" then do the restore with the tabs listed so the offending tab and website can be eliminated so as to avoid the security issue or web page that hangs Firefox.

Reproducible: Sometimes

Steps to Reproduce:
1.Open a webpage that presents a threat and requires you to answer a dialog box to close it. This normally results in the installation of Malware on the system.
2.
3.

Comment 1

[[not reading bugmail]]

The history settings currently override startup setting here.  If you crash or kill, session restore if running should ask you which tabs you want to restore which you can then select manually.  There is a workaround already in place.

Comment 2

[B.J. Herbison]

Dale, are you happy with the response in comment 1?

Addendum to comment 1: The option to select which tabs to restore works if the process is killed, but not if control-C is used to kill the process (Fx4Beta8 on Ubuntu). Sometimes after firefox is killed with control-c running firefox again will restore all tabs without giving the offer to select the tabs to restore.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

This isn't a bug, it's by design. We will attempt to restore your tabs following a crash (because crashing isn't intentional). We treat killing the process as crashing.

Following a couple crashes in a row, we will show about:sessionrestore which allows you to select your tabs to restore.

(In reply to comment #2)
> Addendum to comment 1: The option to select which tabs to restore works if the
> process is killed, but not if control-C is used to kill the process (Fx4Beta8
> on Ubuntu). Sometimes after firefox is killed with control-c running firefox
> again will restore all tabs without giving the offer to select the tabs to
> restore.

This is probably coincidental. You likely had crashed once (probably via testing ctrl-c) so that's why killing showed about:sessionrestore the 2nd time (since we had recorded multiple crashes in a row). But killing via ctrl-c was done first or just hadn't recorded that there was a previous crash.

Comment 4

[u279076]

Verified INVALID.