571750 - Hide keyboard shortcuts in the Firefox button menu

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Dão Gottwald [:dao]]

Attachment 448663 [details] doesn't show keyboard shortcuts in the menu. We currently show them, as this is the default behavior. Should we hide them?

Comment 1

[Peter Henkel [:Terepin]]

I'd say yes. It looks much more cleaner and less cluttered without them.

Comment 2

[tymerkaev]

(In reply to comment #1)
> I'd say yes. It looks much more cleaner and less cluttered without them.

Keyboard shortcuts using for fast access; if you hide it, no one will know what shortcuts he should be use.

Comment 3

[Peter Henkel [:Terepin]]

You can always find them in menu bar by pressing alt kyebord. Besides, you don't need looking at them everytime, plus what's the point of keybord shortcuts when you have to open the menu anyway to see them? As soon as you learn them, you don't need to check them and for others users, who don't use them at all (like myself), they would be just uneccesary vaste of space.

Comment 4

[tymerkaev]

But app button will be shown by default, and for see what keyboard shortcuts users should they must switch to menu bar, see, learn and unswitch. So hard... I think faaborg just forget about draw it.

Comment 5

[WulfTheSaxon [:Wulf]]

Isn't there an OS setting somewhere that could be obeyed?

Comment 6

[David Vo [:auscompgeek]]

Yeah, we should just obey the OS setting, I actually have it set because I don't always use the mouse. Even so, if we actually don't obey it, users can just use the Alt key to show the shortcuts.

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

This type of control commonly displays a custom panel (paint, wordpad, office).  While a common OS control, there isn't really a standard widget for us to invoke for this panel. We'll be making a custom one that matches the general style, and doesn't include keyboard shortcuts for simplicity.  Sub-menus will remain fully native.  For keyboard shortcut discoverability, we'll be relying on support documents, the legacy menu bar, and perhaps an interface similar to gmail that displays all shortcuts in an overlay in response to a shortcut.

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

If the purpose of the button is to be a complement for people hiding the menubar, relying on an hidden bar for discoverability sounds like a strange bet.

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

on the other side, would be cool to have about:shortcuts

Comment 10

[Tan Wei Lin Jason [:Ryuji]]

Why don't just make this another option? 

To allow keyboard shortcuts in Firefox menu or to disable them in the Firefox menu

Comment 11

[Dão Gottwald [:dao]]

Attachment: patch

Comment 12

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/0247a1f85bca

Comment 13

[pal-moz]

shortcuts for "Clear Recent History","Show All History",Customize>Sidebars>Bookmarks/History are still there.
intended ?

no shortcuts, "Attachment 448663 [details]"

Comment 14

[Dão Gottwald [:dao]]

Yes, this bug is only about the top level panel.

Comment 15

[Tan Wei Lin Jason [:Ryuji]]

So you intend to keep keyboard shortcuts for the lower levels? 

or you are going to remove them in the future?

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

The appmenu submenus that don't display keyboard shortcuts have a weird extra vertical line between the submenu and the submenu's dropshadow.

For example, the "Developer" and "Customize" submenus have the line, while "History" and "Customize" -> "Sidebars" don't.

The "Print" menu doesn't have the extra line, but it's also formatted differently with that split menu type.

Regression from this bug, maybe?

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Only happens with directwrite enabled, I think.