TM: slow arrays don't need special objectops

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: gal, Assigned: gal)

Tracking

Other Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

8 years ago
I think this is a left-over from when slow arrays had a weird enumerator handling that dealt with slowification during iteration.
(Assignee)

Comment 2

8 years ago
Created attachment 450970 [details] [diff] [review]
patch
Assignee: general → gal
(Assignee)

Updated

8 years ago
Attachment #450970 - Flags: review?(mrbkap)
You can also remove slowarray_addProperty(), AFAICT.

This will cause merge conflicts for my type-specific arrays patch.
(In reply to comment #3)
> You can also remove slowarray_addProperty(), AFAICT.

Hmm, no, scratch that, I was mixing this up with js_SlowArrayClass.  (Hmm, that's odd that we have some class methods in JSClass and some in JSObjectOps.)
(Assignee)

Comment 5

8 years ago
Its a layering. ObjectOps implements object behavior ("the hashtable"), Class observes object behavior ("as you put this in the hashtable, call me first so I might change or observe the value on the fly").

Updated

8 years ago
Attachment #450970 - Flags: review?(mrbkap) → review+
Andreas asked and we reconstructed that the only reason slow arrays had custom ops was for custom iteration. So this is a followup to fastiterators, in a sense.

/be
Landed for Andreas (I need this for other work, myself):

http://hg.mozilla.org/tracemonkey/rev/e6d125e859bf

/be
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: fixed-in-tracemonkey

Comment 8

8 years ago
http://hg.mozilla.org/mozilla-central/rev/e6d125e859bf
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.