Closed
Bug 571866
Opened 14 years ago
Closed 14 years ago
--browser-chrome test for fennec preferences and text values
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: jmaher, Assigned: adifire)
References
Details
Attachments
(1 file, 2 obsolete files)
10.49 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
* Verify preferences and text 1) click preferences button to view preferences 2) for each preference 2.1) verify the text 2.2) the button/option type (yes/no-checkbox, select dialog, link to page, submit button) 2.3) verify the height of each field is the same 3) verify content and "privacy & security" sections are grey and the same height. 4) return to main page (click the back button in the preferences)
Reporter | ||
Comment 1•14 years ago
|
||
step 2.2 could be confusing. Most items are checkboxes disguised as yes/no fields (I believe via css). We need to verify these are the right type of form element and the right attributes for each element. For things like homepage, that is a select dialog and there are other links and buttons throughout. I would take a working version of fennec and design the test case around what is currently in the preferences. Keep in mind that we have different options for different platforms/versions, so this will be a test case we need to revisit in the future (please put some comments in the test case)
Assignee | ||
Comment 2•14 years ago
|
||
I have not added test to check the grey colors. And there must be a test to check to check for yes/no button, currently it only checks if it exists.
Assignee | ||
Comment 3•14 years ago
|
||
Attachment #462084 -
Attachment is obsolete: true
Reporter | ||
Updated•14 years ago
|
Attachment #463160 -
Flags: review?(mbrubeck)
Comment 4•14 years ago
|
||
Comment on attachment 463160 [details] [diff] [review] Added expected values, changes in height check >diff -r 0353438c1604 chrome/content/browser.js >--- a/chrome/content/browser.js Mon Aug 02 21:12:14 2010 +0530 >+++ b/chrome/content/browser.js Thu Aug 05 20:01:30 2010 +0530 >@@ -1,4 +1,4 @@ >-// -*- Mode: js2; tab-width: 2; indent-tabs-mode: nil; js2-basic-offset: 2; js2-skip-preprocessor-directives: t; -*- >+dow// -*- Mode: js2; tab-width: 2; indent-tabs-mode: nil; js2-basic-offset: 2; js2-skip-preprocessor-directives: t; -*- Looks like this snuck in by accident; please remove it. Aside from that, looks great. r=mbrubeck
Attachment #463160 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 5•14 years ago
|
||
Attachment #463160 -
Attachment is obsolete: true
Assignee | ||
Updated•14 years ago
|
Attachment #463245 -
Flags: review?(mbrubeck)
Updated•14 years ago
|
Attachment #463245 -
Flags: review?(mbrubeck) → review+
Comment 6•14 years ago
|
||
http://hg.mozilla.org/mobile-browser/rev/29ddce25b28c
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 7•13 years ago
|
||
Verified fixed on: Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110921 Firefox/9.0a1 Fennec/9.0a1 Device: HTC Desire OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•