Stop using nsILoadGroup to get URI

RESOLVED FIXED

Status

Fennec Graveyard
General
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

Details

Attachments

(1 attachment)

Created attachment 451063 [details] [diff] [review]
patch

We started to use nsILoadGroup (QI'ed from browser.webNavigation) to get the URI very early in the page load process. We can't do this in e10s, since browser.webNavigation is faked.

We should be able to set browser.currentURI to the right URI very early though, so this might not be a problem in e10s.

This patch removes the problem code. We should make sure that bug 521828 does not regress.
Attachment #451063 - Flags: review?(21)
Comment on attachment 451063 [details] [diff] [review]
patch

(In reply to comment #0)
> Created an attachment (id=451063) [details]
> patch
> 
> We started to use nsILoadGroup (QI'ed from browser.webNavigation) to get the
> URI very early in the page load process. We can't do this in e10s, since
> browser.webNavigation is faked.
> 
> We should be able to set browser.currentURI to the right URI very early though,
> so this might not be a problem in e10s.

Looking at browser.xml it looks like we're setting it as soon as we call loadURI so I think it should be fine.
Attachment #451063 - Flags: review?(21) → review+
pushed to m-b:
http://hg.mozilla.org/mobile-browser/rev/0a09ff4ca657
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.