572084 - Thunderbird Text gets background shadow with some personas/Lightweight themes

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mark Banner (:standard8)]

Attachment: Screenshot of background shadow on text

With some personas, I'm seeing a background shadow on text in the message header pane, the quick filter bar and other areas.

This is on 3.1 and trunk Mac builds. Screenshot attached.

I guess this is something to do with our lightweight theme support.

Also I've seen something similar with Lightning on Windows builds.

Hoping Andreas may be able to take a look at this...

Comment 1

[Andreas Nilsson (:andreasn)]

Agreed, it makes sense for the Ice Age theme (and others) to use shadows for the menubar and statusbar, but not in the other places. Patch coming up shortly.

Comment 2

[Andreas Nilsson (:andreasn)]

Attachment: no shadows inside #mailContent

This disables all shadows inside the #mailContent, ie anything inside the tab(s).
Needs to double check this works on the other platforms too before I ask for review.

Comment 3

[Andreas Nilsson (:andreasn)]

Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

setting Mark as reviewer, since he's done the past personas reviews. Please reassign if you're too busy.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

Yep, looks good to me.

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

so easy!

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/678b65a51740

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

Flagging this now for 3.1.1 approval so I don't forget about it.

Should be low risk as it is limited to lightweight themes only.

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

a=Standard8 for comm-1.9.2. This should land on default on comm-1.9.2 for now, and I'll sort out branches later.

Comment 9

[Mark Banner (:standard8)]

Checked in to comm-1.9.2 and the 3.1.1 relbranch for build 2:

http://hg.mozilla.org/releases/comm-1.9.2/rev/f0c904a80b00
http://hg.mozilla.org/releases/comm-1.9.2/rev/3cf5ffeb6260

Comment 10

[rsx11m]

Per bug 576271, issue appears to be fixed on trunk but not in 3.1.1 release.

Comment 11

[Mark Banner (:standard8)]

(In reply to comment #10)
> Per bug 576271, issue appears to be fixed on trunk but not in 3.1.1 release.

I'll comment on that bug. Generally I think the remaining parts are a lightning issue, but I wonder if there's something that would be better done in Thunderbird.