Closed Bug 572084 Opened 10 years ago Closed 10 years ago

Thunderbird Text gets background shadow with some personas/Lightweight themes

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set

Tracking

(thunderbird3.1 .1-fixed)

RESOLVED FIXED
Thunderbird 3.3a1
Tracking Status
thunderbird3.1 --- .1-fixed

People

(Reporter: standard8, Assigned: andreasn)

References

()

Details

(Keywords: polish, Whiteboard: [gs])

Attachments

(2 files)

With some personas, I'm seeing a background shadow on text in the message header pane, the quick filter bar and other areas.

This is on 3.1 and trunk Mac builds. Screenshot attached.

I guess this is something to do with our lightweight theme support.

Also I've seen something similar with Lightning on Windows builds.

Hoping Andreas may be able to take a look at this...
Agreed, it makes sense for the Ice Age theme (and others) to use shadows for the menubar and statusbar, but not in the other places. Patch coming up shortly.
This disables all shadows inside the #mailContent, ie anything inside the tab(s).
Needs to double check this works on the other platforms too before I ask for review.
Attachment #451562 - Attachment is patch: true
Attachment #451562 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

setting Mark as reviewer, since he's done the past personas reviews. Please reassign if you're too busy.
Attachment #451562 - Flags: ui-review?(clarkbw)
Attachment #451562 - Flags: review?(bugzilla)
Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

Yep, looks good to me.
Attachment #451562 - Flags: review?(bugzilla) → review+
Attachment #451562 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

so easy!
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/678b65a51740
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

Flagging this now for 3.1.1 approval so I don't forget about it.

Should be low risk as it is limited to lightweight themes only.
Attachment #451562 - Flags: approval-thunderbird3.1.1?
Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

a=Standard8 for comm-1.9.2. This should land on default on comm-1.9.2 for now, and I'll sort out branches later.
Attachment #451562 - Flags: approval-thunderbird3.1.1? → approval-thunderbird3.1.1+
Keywords: checkin-needed
Whiteboard: checkin needed to comm-1.9.2 default
Whiteboard: checkin needed to comm-1.9.2 default → [gs][checkin needed to comm-1.9.2 default]
Checked in to comm-1.9.2 and the 3.1.1 relbranch for build 2:

http://hg.mozilla.org/releases/comm-1.9.2/rev/f0c904a80b00
http://hg.mozilla.org/releases/comm-1.9.2/rev/3cf5ffeb6260
Keywords: checkin-needed
Whiteboard: [gs][checkin needed to comm-1.9.2 default] → [gs]
Depends on: 576271
Per bug 576271, issue appears to be fixed on trunk but not in 3.1.1 release.
(In reply to comment #10)
> Per bug 576271, issue appears to be fixed on trunk but not in 3.1.1 release.

I'll comment on that bug. Generally I think the remaining parts are a lightning issue, but I wonder if there's something that would be better done in Thunderbird.
You need to log in before you can comment on or make changes to this bug.