Thunderbird Text gets background shadow with some personas/Lightweight themes

RESOLVED FIXED in Thunderbird 3.3a1

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: standard8, Assigned: andreasn)

Tracking

({polish})

Trunk
Thunderbird 3.3a1
polish

Thunderbird Tracking Flags

(thunderbird3.1 .1-fixed)

Details

(Whiteboard: [gs], URL)

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
Created attachment 451242 [details]
Screenshot of background shadow on text

With some personas, I'm seeing a background shadow on text in the message header pane, the quick filter bar and other areas.

This is on 3.1 and trunk Mac builds. Screenshot attached.

I guess this is something to do with our lightweight theme support.

Also I've seen something similar with Lightning on Windows builds.

Hoping Andreas may be able to take a look at this...
(Assignee)

Comment 1

8 years ago
Agreed, it makes sense for the Ice Age theme (and others) to use shadows for the menubar and statusbar, but not in the other places. Patch coming up shortly.
(Assignee)

Comment 2

8 years ago
Created attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

This disables all shadows inside the #mailContent, ie anything inside the tab(s).
Needs to double check this works on the other platforms too before I ask for review.
(Assignee)

Updated

8 years ago
Attachment #451562 - Attachment is patch: true
Attachment #451562 - Attachment mime type: application/octet-stream → text/plain
(Assignee)

Comment 3

8 years ago
Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

setting Mark as reviewer, since he's done the past personas reviews. Please reassign if you're too busy.
Attachment #451562 - Flags: ui-review?(clarkbw)
Attachment #451562 - Flags: review?(bugzilla)
(Reporter)

Comment 4

8 years ago
Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

Yep, looks good to me.
Attachment #451562 - Flags: review?(bugzilla) → review+
Attachment #451562 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

so easy!
(Reporter)

Updated

8 years ago
Keywords: checkin-needed
(Reporter)

Comment 6

8 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/678b65a51740
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
(Reporter)

Comment 7

8 years ago
Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

Flagging this now for 3.1.1 approval so I don't forget about it.

Should be low risk as it is limited to lightweight themes only.
Attachment #451562 - Flags: approval-thunderbird3.1.1?
(Reporter)

Comment 8

8 years ago
Comment on attachment 451562 [details] [diff] [review]
no shadows inside #mailContent

a=Standard8 for comm-1.9.2. This should land on default on comm-1.9.2 for now, and I'll sort out branches later.
Attachment #451562 - Flags: approval-thunderbird3.1.1? → approval-thunderbird3.1.1+
(Reporter)

Updated

8 years ago
Keywords: checkin-needed
Whiteboard: checkin needed to comm-1.9.2 default
(Reporter)

Updated

8 years ago
Whiteboard: checkin needed to comm-1.9.2 default → [gs][checkin needed to comm-1.9.2 default]
(Reporter)

Comment 9

8 years ago
Checked in to comm-1.9.2 and the 3.1.1 relbranch for build 2:

http://hg.mozilla.org/releases/comm-1.9.2/rev/f0c904a80b00
http://hg.mozilla.org/releases/comm-1.9.2/rev/3cf5ffeb6260
status-thunderbird3.1: wanted → .1-fixed
Keywords: checkin-needed
Whiteboard: [gs][checkin needed to comm-1.9.2 default] → [gs]

Updated

8 years ago
Depends on: 576271

Comment 10

8 years ago
Per bug 576271, issue appears to be fixed on trunk but not in 3.1.1 release.
(Reporter)

Comment 11

8 years ago
(In reply to comment #10)
> Per bug 576271, issue appears to be fixed on trunk but not in 3.1.1 release.

I'll comment on that bug. Generally I think the remaining parts are a lightning issue, but I wonder if there's something that would be better done in Thunderbird.
You need to log in before you can comment on or make changes to this bug.