572089 - jsmicro directory needs to control ASC settings

Status: RESOLVED FIXED

(Tamarin Graveyard :: Build Config, defect, P2)

Description

[Lars T Hansen]

It's OK to compile with -strict but not with -AS3 in this directory.  Ideally we'd compile with neither (the Makefile has just -optimize, which is essentially a no-op from what I can tell).

Comment 1

[Lars T Hansen]

Attachment: Patch

This goes into test/performance/jsmicro.

Comment 2

[Brent Baker]

Comment on attachment 451254 [details] [diff] [review]
Patch

Looking at the code in runtestsBase.py I think there is a bug there that you cannot override extraArgs that are passed into compile_test(). I will dig a little deeper and possibly submit a new bug, but currently this patch will still compile with -AS3 and -optimize

Comment 3

[Lars T Hansen]

Nice find.  I was a little perplexed that applying this patch did not change the results relative to compiling with -AS3, and that's presumably the reason.

Comment 4

[Brent Baker]

Yeah with the proper fix running array-push-1.as went from 208 to 26 on my machine

Comment 5

[Brent Baker]

Comment on attachment 451254 [details] [diff] [review]
Patch

Digging deeper into the suite framework code it does not appear that the override| even works. The code that is in place to handle whether to merge or override will only ever be in the /merge/ mode.

Suggest for now this patch be changed to have:

merge| -optimize -no-AS3

Comment 6

[Lars T Hansen]

I'm in no rush, I'll await the fix for bug 572120.

Comment 7

[Lars T Hansen]

tamarin-redux changeset:   4848:3ab73daa0291