572101 - debug prefs are resetted often while debugging

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Why are those prefs needed at all? Neither of them are required to have a default, so I would just remove them.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 451267 [details] [diff] [review]
Patch


>+#ifdef MOZ_OFFICIAL_BRANDING
> pref("javascript.options.showInConsole", false);
> pref("browser.dom.window.dump.enabled", false);
>+#endif

Shouldn't we have an #else here to set them to true? Do these default to true somewhere?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

As pointed out, now that about:config works well, let's just remove these prefs

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/af21af780caa

Comment 6

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:1.9.3a6pre) Gecko/2010621 Namoroka/3.7a6pre Fennec/2.0a1pre