572110 - buglist.cgi: Use of uninitialized value in lc at Bugzilla/Search.pm line 391, <DATA> line 275., referer: https://***/describecomponents.cgi

Status: RESOLVED WORKSFORME

(Bugzilla :: Query/Bug List, defect)

Description

[Gabor Simon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3
Build Identifier: 3.6

The abovementioned message is generated into the webserver log several times
when a bug query is issued for a newly created component that has no bugs yet.


Reproducible: Always

Steps to Reproduce:
1. Create a new product and a new component in it.
2. 'Browse' for its bugs
3. Check your webserver's log
Actual Results:  
Messages like $summary and for Search.pm:392 as well.

Expected Results:  
Remain silent.

Comment 1

[Gabor Simon]

Seems to happen because in init() $params->param('chfieldfrom') and
$params->param('chfieldto') are used before they were tested against
undef.

The patch below seems to solve the issue.

--- Bugzilla.orig/Search.pm     2010-06-15 15:42:13.090877000 +0200
+++ Bugzilla/Search.pm  2010-06-15 15:46:04.398090000 +0200
@@ -388,8 +388,8 @@
         }
     }
 
-    my $chfieldfrom = trim(lc($params->param('chfieldfrom'))) || '';
-    my $chfieldto = trim(lc($params->param('chfieldto'))) || '';
+    my $chfieldfrom = trim(lc($params->param('chfieldfrom') || ''));
+    my $chfieldto = trim(lc($params->param('chfieldto') || ''));
     $chfieldfrom = '' if ($chfieldfrom eq 'now');
     $chfieldto = '' if ($chfieldto eq 'now');
     my @chfield = $params->param('chfield');

Comment 2

[Max Kanat-Alexander]

Hey Gabor. Sorry for the REALLY delayed response, but it looks like we actually did fix this, at least in 4.0, in exactly the way you suggest. :-)