572120 - Unable to override extraArgs in runtestBase.compile_test()

Status: VERIFIED FIXED

(Tamarin Graveyard :: Tools, defect, P3)

Description

[Brent Baker]

The testing suite code has the ability to override/add additional asc args to the compilation of the test media by having either a <filename>.asc_args file or a dir.asc_args file. (see test/performance/dir.asc_args for more documentation). 

There is a problem however that you are unable to override any args that are passed into the compile_test() via the extraArgs param. This param is currently only used in the performance suite and is currently passing /-AS3 and -optimize/. 

There is a new jsmicro performance suite that was added that needs to have the ability to disable the -AS3 switch when compiling.

Comment 1

[Brent Baker]

Attachment: allow compile_test() extraArgs to be overridden

This will allow extraArgs to be overridden by use of *.asc_args

Also add a verbose call to show the compilation command (use -v to see how the media is compiled)

I would like Chris to review this, I can see no reason why the extraArgs should not be overridden if a *.asc_args file is present.

Comment 2

[Brent Baker]

Attachment: v2. patch to override extraArgs and make /override|/ in asc_args actually work

There was a logic error in the check to see if the /mode/ was recognized, should have been and /and/ check not /or/. This error made the mode always default to /merge/ and override never worked, which can also be seen by the fact that the override path referenced a variable that did not exist.

Comment 3

[Chris Peyer]

Comment on attachment 451313 [details] [diff] [review]
v2. patch to override extraArgs and make /override|/ in asc_args actually work

Looks good - tested against a variety of dir.asc_arg inputs.

Comment 4

[Brent Baker]

Comment on attachment 451313 [details] [diff] [review]
v2. patch to override extraArgs and make /override|/ in asc_args actually work

patch pushed changeset - 4841:0f0fc3c46227

Comment 5

[Brent Baker]

Pushed a follow up patch:

changeset:   4843:e2ba887d6270
description:
Bug 572120: fix an issue with ascargs not having a trailing space when appending extraArgs to it (r+cpeyer)