Remove call to check-locales.pl for Sunbird

RESOLVED FIXED

Status

Calendar
Sunbird Only
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

Details

Attachments

(1 attachment)

Spinoff of bug Bug 570680 for Sunbird

This was added to let localizers know that they needed to change
${BrandShortName} to $BrandShortName and ${BrandFullName} to $BrandFullName
instead of changing the string names.

check-locales.pl won't be removed until all apps using it no longer need to use
it.
Robert, did you check whether we are actually still using that file?

An mxr search on the comm-central, l10n-mozilla-1.9.2 and l10n-central repos for the calendar/locales/installer files didn't bring anything up for me.

That would indicate to me, that we are safe to remove check-locales.pl, right?
OS: Windows 7 → All
Hardware: x86 → All
It is still being used
http://mxr.mozilla.org/comm-central/source/calendar/locales/Makefile.in#95

but it doesn't need to be called any more. It was added to simplify a change to the installer locales.
btw: the entire tests section of the makefile on line 95 can be removed as long as the following is also removed
http://mxr.mozilla.org/comm-central/source/calendar/locales/Makefile.in#111
Created attachment 451532 [details] [diff] [review]
patch
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #451532 - Flags: review?(bugzilla)
Comment on attachment 451532 [details] [diff] [review]
patch

r=sipaq

Please check this in, any time you want to on comm-central
Attachment #451532 - Flags: review?(bugzilla) → review+
Thanks for the quick review!

Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/5b527a449da3
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.