flush prefs on android app pause

RESOLVED FIXED

Status

()

Core
Widget: Android
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: blassey, Assigned: blassey)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 451435 [details] [diff] [review]
patch

once paused we may not resume, might as well flash the prefs at that point
Attachment #451435 - Flags: review?(mwu)

Comment 1

8 years ago
Comment on attachment 451435 [details] [diff] [review]
patch

I'd remove the debugging log on the java side. Please check if SavePrefFile is ok to call from another thread.
Attachment #451435 - Flags: review?(mwu) → review+

Updated

8 years ago
Attachment #451435 - Flags: review+

Comment 2

8 years ago
Comment on attachment 451435 [details] [diff] [review]
patch

Hmm I don't really see any evidence that it's safe to call SavePrefFile from another thread.

Ideally we'd fire something off to observers to tell them to prepare to exit but I haven't found something that does exactly what we want. Perhaps profile-before-change? Regardless, we'll probably have to put this on the gecko main thread through an event.
Created attachment 452062 [details] [diff] [review]
patch

this adds a pause event and also does some shut down cleanup stuff for the close event
Attachment #452062 - Flags: review?(mwu)
(Assignee)

Updated

8 years ago
Attachment #451435 - Attachment is obsolete: true

Updated

8 years ago
Attachment #452062 - Flags: review?(mwu) → review+
pushed http://hg.mozilla.org/mozilla-central/rev/5365d2057b91
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Updated

7 years ago
Assignee: nobody → blassey.bugs
You need to log in before you can comment on or make changes to this bug.