572287 - Don't leak mThebesComputationalSurface

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Currently it leaks. This is a problem once we start tracking leaked surfaces.

The patch also renames the member to gThebesComputationalSurface.

Comment 1

[Jonathan Watt [:jwatt]]

Comment on attachment 451472 [details] [diff] [review]
fix

>+nsSVGUtils::Shutdown()
>+{
>+  NS_IF_RELEASE(gThebesComputationalSurface);
> }

Maybe null it out too?

Comment 2

[Josh Matthews [:jdm]]

The NS_*_RELEASE macros null out their argument after releasing.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

http://hg.mozilla.org/mozilla-central/rev/41553c0928e1