572390 - [DW]The height of the location bar increases for several pixels when "Site Identity Button" is green/blue.

Status: VERIFIED WORKSFORME

(Core :: Graphics, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.6pre) Gecko/20100615 Firefox/3.6.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; WOW64; en-US; rv:1.9.3a6pre) Gecko/20100616 Minefield/3.7a6pre ID:20100616035900

In classic window style and DW/D2D enabled,
The height of the location bar increases for several pixels when "Site Identity Button" is green/blue.

Reproducible: Always

Steps to Reproduce:
1.Make sure that desktop to be classic window style.
2.Start Minefield with DW/D2D enabled clean profile.
3.Go http://www.mozilla.org/projects/minefield/ which is normal "Site Identity Button"
4.Go https://addons.mozilla.org/en-US/firefox/ which is green "Site Identity Button"
5. Switch step 3 and 4
Actual Results:  
The height of the location bar increases for several pixels when "Site Identity Button" is colored

Expected Results:  
Should not increase

Regression window:

Works:
http://hg.mozilla.org/mozilla-central/rev/23e09c2ded59
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100406 Minefield/3.7a4pre ID:20100406135633

Fails:
http://hg.mozilla.org/mozilla-central/rev/64ebf70ed4a2
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a4pre) Gecko/20100406 Minefield/3.7a4pre ID:20100406151247

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=23e09c2ded59&tochange=64ebf70ed4a2

Comment 1

[Bas Schouten (:bas.schouten)]

Related to the rounding probably.

Comment 2

[Jonathan Kew [:jfkthame]]

(In reply to comment #1)
> Related to the rounding probably.

Seems likely, given the pushlog range. But I'm puzzled why the color of the "site identity button" should affect it. Is something else also changing at the same time?

Comment 3

[Alice0775 White]

Attachment: testcase

Just load testcase.
Result of boxObject.height is different as follows.

When DW enabled : 25px
When DW disabled  : 23px

Comment 4

[Alice0775 White]

In addition to the comment #3

Under condition of DW enabled.
http://hg.mozilla.org/mozilla-central/rev/23e09c2ded59 : returns 23px
http://hg.mozilla.org/mozilla-central/rev/64ebf70ed4a2 : returns 25px

And I think 23px is correct value.

Comment 5

[Alice0775 White]

Because of same regression range in comment #0, Bug 569106 seems to be same  phenomenon.

Comment 6

[Alice0775 White]

I confirmed in local build, 4365eabf7fb0 cause this issue.

Comment 7

[Alice0775 White]

I cannot reproduce any more.
http://hg.mozilla.org/mozilla-central/rev/9a6c139a4e58
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110602 Firefox/7.0a1 ID:20110602030726