572510 - User-profile pages don't validate to their doctype

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://preview.addons.mozilla.org/z/en-US/firefox/user/235535/ doesn't validate to its doctype:

http://validator.w3.org/check?uri=https%3A%2F%2Fpreview.addons.mozilla.org%2Fz%2Fen-US%2Ffirefox%2Fuser%2F235535%2F&charset=%28detect+automatically%29&doctype=Inline&group=0

Comment 1

[Wil Clouser [:clouserw]]

Attachment: validation fixes

Patch should fix this.  My main question is the |escape - that should be alright there, right?

Comment 2

[Jeff Balogh (:jbalogh)]

Comment on attachment 452060 [details] [diff] [review]
validation fixes


>-    {% trans url=base|urlparams(type='suggested'),
>+    {% trans url=base|urlparams(type='suggested')|escape,

Seems fine to me.


>-          <p class="description" locale="{{ review.body.locale }}">
>+          <p class="description" lang="{{ review.body.locale }}">

We have {{ review.body|locale_html }} for this.

Comment 3

[Wil Clouser [:clouserw]]

wfm, thanks.

http://github.com/jbalogh/zamboni/commit/3146ded00b7332c79cc78bb6b4e8477676302caa

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Thx, Wil: verified FIXED.