Closed
Bug 572545
Opened 14 years ago
Closed 14 years ago
nightly.mozilla.org should advertise x64 builds
Categories
(Websites :: Other, defect)
Websites
Other
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: kbrosnan, Assigned: kbrosnan)
References
Details
Attachments
(2 files, 1 obsolete file)
241.70 KB,
image/png
|
Details | |
2.26 KB,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
If the plan is to ship 64-bit builds in Firefox 4 along side 32-bit builds nightly should advertise them.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #451722 -
Flags: review?(dolske)
Comment 2•14 years ago
|
||
Comment on attachment 451722 [details] [diff] [review] Add 64-bit Windows and Mac 10.6 >diff --git a/scrape.py b/scrape.py >--- a/scrape.py >+++ b/scrape.py >@@ -19,17 +19,19 @@ class BuildDisplay(): > self.suffix = suffix > self.extension = extension > self.name = name > self.css_class = css_class > > files_wanted = [ > # (suffix, extension, name, css_class) > BuildDisplay(".win32", "zip", "Windows", "windows zip"), >+ BuildDisplay(".win64-x86_64", "zip", "Windows 64-bit", "windows zip"), Per bug 572325, this should be a link to the installer now. PreemptiveNit: Line up the columns here, since "win64-x86_64.installer" is going to be longer than anything else. Add "x64" in class for consistency. > BuildDisplay(".mac", "dmg", "Mac", "mac dmg"), >+ BuildDisplay(".mac64", "dmg", "Mac 64-bit 10.6", "mac dmg"), Add "x64" in class here too. "Mac 64-bit for 10.6"? Could be a bit ambiguous otherwise? Finally, I suspect the page is going to be awkwardly wide with the addition of 2 more builds... Feel up to doing some page tweaks to get the Linux builds on a separate line, or something like that?
Attachment #451722 -
Flags: review?(dolske) → review-
Assignee | ||
Comment 3•14 years ago
|
||
Assignee | ||
Comment 4•14 years ago
|
||
Revised patch, should address all the comments.
Assignee: nobody → kbrosnan
Attachment #451722 -
Attachment is obsolete: true
Attachment #452269 -
Flags: review?(dolske)
Updated•14 years ago
|
Attachment #452269 -
Flags: review?(dolske) → review+
Comment 5•14 years ago
|
||
Pushed http://hg.mozilla.org/webtools/nightly/rev/c86518207ad1
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•14 years ago
|
||
Verified.
Assignee | ||
Updated•14 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•