Closed
Bug 572567
Opened 14 years ago
Closed 13 years ago
Cannot get to preferences from new about:addons context menu
Categories
(Other Applications :: ChatZilla, defect)
Other Applications
ChatZilla
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: bugzilla-mozilla-20000923)
References
Details
(Keywords: regression, Whiteboard: [cz-0.9.87])
Attachments
(1 file)
914 bytes,
patch
|
samuel
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce: 1/ Use a build of SeaMonkey (or probably Firefox too) with the new add-on manager. 2/ Bring up context menu on Chatzilla listing under Extensions and select preferences. Expect result 1/ Preferences for Chatzilla Actual result 1/ Opens empty browser window. 2/ Following message in error console: Error: Permission denied for <moz-nullprincipal:{025f5402-0439-41e7-aabe-0b75f89eaca7}> (document.domain=<moz-nullprincipal:{025f5402-0439-41e7-aabe-0b75f89eaca7}>) to get property Window.openDialog from <> (document.domain has not been set). Source File: javascript:opener.openDialog('chrome://chatzilla/content/config.xul','','chrome,modal,resizable');window.close(); Line: 1 Workaround 1/ In SeaMonkey can get to preferences from main preferences window.
(In reply to comment #0) FWIW, this works fine on Firefox.
(In reply to comment #1) > (In reply to comment #0) > FWIW, this works fine on Firefox. Nevermind. Chatzilla's not working.
Comment 3•14 years ago
|
||
So very very tempted to WONTFIX this - there's no reason for Chatzilla to be using a javascript: URI there. And ViewSourceWith is the only other addon I could find that's doing that (after a quick MXR search).
Comment 4•14 years ago
|
||
(In reply to comment #3) > So very very tempted to WONTFIX this - there's no reason for Chatzilla to be > using a javascript: URI there. And ViewSourceWith is the only other addon I > could find that's doing that (after a quick MXR search). Sure there is, the window isn't resizable without it (at least, it never used to be, if Fx passes different parameters by now, that may have changed). See https://bugzilla.mozilla.org/show_bug.cgi?id=245783#c6 .
Comment 5•14 years ago
|
||
(In reply to comment #3) > So very very tempted to WONTFIX this - there's no reason for Chatzilla to be > using a javascript: URI there. And ViewSourceWith is the only other addon I > could find that's doing that (after a quick MXR search). You can't WONTFIX this, it's a Chatzilla bug! But seriously, we've always supported javascript urls in the aboutURL before (or at least we've never denied it) and right now I don't see a reason why we'd stop doing that, because as Gijs says there are reasons why it is sometimes necessary. In this case the only problem I think is that Chatzilla is trying to use the window.opener which probably isn't something useful for the in-content UI.
As Chatzilla needs to support both the old and new versions of the add-on manager I think we need to either be able to support using javascript urls or have a more flexible way of defining OptionURL and aboutURL in extension's install.rdf file.
I'm seeing this behavior in the latest nightly build of Firefox. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b8pre) Gecko/20101031 Firefox/4.0b8pre
Assignee | ||
Comment 10•13 years ago
|
||
I propose we remove the optionURL from install.rdf and only provide access to preferences through ChatZilla, due to a lack of better alternatives. This will be an inconvenience to Firefox 3.6 and earlier users but as Firefox 4 will likely be out by the time the next CZ release happens, it should not make any functional difference to most users (since it will already not work).
Assignee | ||
Comment 11•13 years ago
|
||
I decided to be a little nicer on users; they'll get the options window still but (obviously) no longer resizable.
Updated•13 years ago
|
Attachment #520944 -
Flags: review?(samuel) → review+
Assignee | ||
Comment 12•13 years ago
|
||
http://hg.mozilla.org/chatzilla/rev/b990c4daa5d5
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
Whiteboard: [cz-0.9.87]
You need to log in
before you can comment on or make changes to this bug.
Description
•