572603 - If $action eq 'none' in process_bug.cgi, recent_search_for dies

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Max Kanat-Alexander]

If there's no "bug" object passed to the template in navigate.html.tmpl, recent_search_for dies. I think that's probably OK--it helps us catch errors in how we're calling the templates. However, we should certainly be setting $vars->{bug} to something sensible so that this error stops happening.

Comment 1

[Frédéric Buclin]

How do you trigger this crash exactly?

Comment 2

[Max Kanat-Alexander]

Update any bug on HEAD that isn't in your list, or just don't have a list.

Comment 3

[Max Kanat-Alexander]

Attachment: v1

Okay, in fact this is actually exposing a minor bug that would happen when updating bugs not in your list--you'd get a navigation bar, but it would *always* be empty, because there was no bug object. So I simply don't show the navigation bar if there isn't a bug object, now.

Comment 4

[Frédéric Buclin]

Comment on attachment 453484 [details] [diff] [review]
v1

>+[% RETURN IF !bug %]

I think you should also fix recent_search_for() in Bugzilla/User.pm to return undef when $bug is undefined. r=LpSolit

Comment 5

[Max Kanat-Alexander]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/bug/navigate.html.tmpl
Committed revision 7240.