572640 - e10s HTTP: Serialize nsIMultiplexInputStreams

Status: RESOLVED WONTFIX

(Core :: Networking: HTTP, defect)

Description

[Jae-Seong Lee-Russo]

Attachment: wip

I am stuck here.

I can't make this patch call the right WriteParam/ReadParam for each substream because of ParamTraits<nsIInputStream*>, but ParamTraits<nsIInputStream*> is there to make it compile.

Comment 1

[[e-mail]]

You can do what we did for URI's -- have the various stream implementations inherit from nsIIPCSerializable, and then implement them like so: http://mxr.mozilla.org/mozilla-central/source/netwerk/base/src/nsStandardURL.cpp#2886

Then in ParamTraits<nsIMultiplexInputStream*>::Write(), you just QI to nsIIPCSerializable (and explode if you can't); then call its Write method.

Note that you'll also have to get the CID of the implementation (e.g. http://mxr.mozilla.org/mozilla-central/source/netwerk/ipc/NeckoMessageUtils.h#103), so you can instantiate it on the other side. You should be able to use that ParamTraits<URI> code as a model.

Comment 2

[Jason Duell]

> Then in ParamTraits<nsIMultiplexInputStream*>::Write(), you just 
> QI to nsIIPCSerializable (and explode if you can't)

More politely, you could also check that the QI works before you call the IPDL function, and fail gracefully at that point.  There is no graceful fail once you're within ParamTraits<>.

Comment 3

[Jae-Seong Lee-Russo]

I am confused.  Jason's description in Bug 564553 says that I reconstruct the new stream in chrome, but if I follow this

> You can do what we did for URI's -- have the various stream implementations
> inherit from nsIIPCSerializable, and then implement them like so:
> http://mxr.mozilla.org/mozilla-central/source/netwerk/base/src/nsStandardURL.cpp#2886

how am I going to reconstruct the stream in Read()?  Is this (
http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/PHttpChannelParams.h#198) even necessary?

Comment 4

[[e-mail]]

(In reply to comment #2)
> More politely, you could also check that the QI works before you call the IPDL
> function, and fail gracefully at that point.  There is no graceful fail once
> you're within ParamTraits<>.

Hmm. I'm not sure which approach I like better -- not being able to serialize something should be pretty fatal, IMO. Especially since this stuff could be called from within another Write method, where there's no graceful fail. Doing the QI first makes things kinda ugly. If we wanted to do this, the better approach would be to change the signature of Write() to have a bool return value such that consumers can gracefully fail in general.

Unrelated -- you could instead implement your ParamTraits<nsIMultiplexedInputStream*> as a generic ParamTraits<nsIInputStream*>, and have the multiplexed stream implementation of nsIIPCSerializable do the right thing.

(In reply to comment #3)
> how am I going to reconstruct the stream in Read()?  Is this (
> http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/PHttpChannelParams.h#198)
> even necessary?

No, you'll have to move (part of) that code into the string input stream implementation of nsIIPCSerializable. You can follow the example of http://mxr.mozilla.org/mozilla-central/source/netwerk/ipc/NeckoMessageUtils.h#114.

Comment 5

[Doug Turner (:dougt)]

dan, is this r-?  If so, lets mark it!

Comment 6

[[e-mail]]

Comment on attachment 451892 [details] [diff] [review]
wip

OK!

Comment 7

[Jae-Seong Lee-Russo]

Will be fixed by Bug 564553