Closed
Bug 572647
Opened 15 years ago
Closed 14 years ago
XPCConvert::NativeInterface2JSObject should create COWs automatically
Categories
(Core :: XPConnect, defect)
Tracking
()
People
(Reporter: smaug, Assigned: mrbkap)
References
Details
(Whiteboard: [sg:critical][compartments][hardblocker])
Attachments
(1 obsolete file)
Updated•15 years ago
|
Whiteboard: [sg:critical]
Comment 1•15 years ago
|
||
mrbkap, can you have a look at his one? We're interested in this for branches ASAP.
Assignee: nobody → mrbkap
Updated•15 years ago
|
Whiteboard: [sg:critical] → [sg:critical][critsmash:investigating]
Comment 2•15 years ago
|
||
blake, can we get an ETA on this?
Assignee | ||
Comment 3•15 years ago
|
||
As a note, bug 523994 fixes this in a really clean way (and makes NativeInterface2JSObject actually legible too). Unfortunately, I'm bogged down in fixing-mochitest hell in that bug, so I'll fix this one separately so we can get it landed while I finish bug 523994.
Assignee | ||
Comment 4•15 years ago
|
||
Of special importance in reviewing this patch is the control flow in NI2JSO: I looked carefully and as far as I can tell, it is safe to have an early return here. Also, how we determine that we are returning to content is a little skeezy (using filename flags is pretty terrible). Also, figuring out that the object is chrome is not great. bug 523994 will again come to rescue us.
Attachment #457749 -
Flags: review?(jst)
Updated•15 years ago
|
Attachment #457749 -
Flags: review?(jst) → review+
Updated•15 years ago
|
Whiteboard: [sg:critical][critsmash:investigating] → [sg:critical][critsmash:patch]
Comment 5•15 years ago
|
||
Are we done here? Can we land?
Comment 6•15 years ago
|
||
Test?
Comment 7•15 years ago
|
||
blake?
Assignee | ||
Comment 8•15 years ago
|
||
Sorry, the patch causes a ton of assertions on mochichrome tests. I'll attach a new one tomorrow.
Updated•15 years ago
|
Updated•15 years ago
|
Comment 9•15 years ago
|
||
Where's that new patch, mrbkap?
Updated•15 years ago
|
Attachment #457749 -
Attachment is obsolete: true
Comment 10•15 years ago
|
||
Blake, seriously, is there a new patch coming?
Assignee | ||
Updated•15 years ago
|
Whiteboard: [sg:critical][critsmash:patch] → [sg:critical][critsmash:patch][compartments]
Assignee | ||
Comment 11•15 years ago
|
||
(we'll need to do something special for the older branches)
Comment 12•15 years ago
|
||
As soon as compartments lands, we should verify this is fixed. Marcia?
Comment 13•15 years ago
|
||
Blake: Is there any an easy way I can verify that this bug is fixed? I don't see a testcase readily available.
Comment 14•15 years ago
|
||
Marcia, the testcase in bug 572129 might show whether this got fixed by the compartments landing or not.
Reporter | ||
Comment 15•15 years ago
|
||
Marcia, did you manage to verify whether this is fixed or not?
Comment 16•15 years ago
|
||
When I run the test case from the bug in Comment 14 using Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101116 Firefox/4.0b8pre, I still get the
alert dialog that shows "Components.stack."
Updated•14 years ago
|
Whiteboard: [sg:critical][critsmash:patch][compartments] → [sg:critical][critsmash:patch][compartments]hardblocker
Updated•14 years ago
|
Whiteboard: [sg:critical][critsmash:patch][compartments]hardblocker → [sg:critical][compartments]hardblocker
Updated•14 years ago
|
Whiteboard: [sg:critical][compartments]hardblocker → [sg:critical][compartments][hardblocker]
Comment 17•14 years ago
|
||
So this bug as filed has been fixed, there's remaining bugs on making them default safe (bug 628410).
Marking FIXED.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 18•14 years ago
|
||
Is the fact that bug 572129 is not fixed have any bearing on whether we want to consider this fixed? See https://bugzilla.mozilla.org/show_bug.cgi?id=572129#c23.
Comment 19•14 years ago
|
||
If we're going to fix this on 1.9.2 it needs to be now. If we're not ever going to do it we should just say that.
blocking1.9.1: needed → -
blocking1.9.2: needed → .20+
Assignee | ||
Comment 20•14 years ago
|
||
I don't think we can really fix this on 1.9.2. COWs (as we were hoping to backport them when this bug was filed) have been replaced by new code that is heavily dependent on compartments.
Updated•14 years ago
|
blocking1.9.2: .20+ → needed
Updated•14 years ago
|
Updated•10 years ago
|
Group: core-security → core-security-release
Updated•10 years ago
|
Group: core-security-release
You need to log in
before you can comment on or make changes to this bug.
Description
•