Disabled optgroup handling of the form manager is buggy

VERIFIED FIXED

Status

Fennec Graveyard
General
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: vingtetun)

Tracking

({testcase})

Trunk
x86
Windows 7
testcase
Bug Flags:
in-testsuite ?

Details

(Whiteboard: formfill)

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
Created attachment 452012 [details]
testcase

See testcase, with fennec I don't see the "optgroup title" text in the optgroup line.
Also, which you can see with the second select, the disabled attribute for the optgroup isn't obeyed for the form manager. Option 3 can be selected in Fennec.

Some other bugs, that I'm seeing:
- Option 4 of the second select can't be selected (which is correct, because it's disabled), but it looks like an ordinary option. It should look disabled.
- Shouldn't option3 of the second select be indented, since it's part of an optgroup?
Whiteboard: formfill
(In reply to comment #0)
> Created attachment 452012 [details]
> testcase
> 
> See testcase, with fennec I don't see the "optgroup title" text in the optgroup
> line.
This should be fixed by bug 573561

> Also, which you can see with the second select, the disabled attribute for the
> optgroup isn't obeyed for the form manager. Option 3 can be selected in Fennec.
> 
> Some other bugs, that I'm seeing:
> - Option 4 of the second select can't be selected (which is correct, because
> it's disabled), but it looks like an ordinary option. It should look disabled.
> - Shouldn't option3 of the second select be indented, since it's part of an
> optgroup?

That's the main part of the bug, I've changed the title to reflect this.
Depends on: 573561
Summary: Optroup handling of the form manager is buggy → Disabled optgroup handling of the form manager is buggy
Created attachment 459827 [details] [diff] [review]
Patch

This just change the color of a disabled item and prevent any mouse events on it.
Assignee: nobody → 21
Attachment #459827 - Flags: review?(mark.finkle)
Attachment #459827 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/5cb8c1852a81
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
verified FIXED on build:
Mozilla/5.0 (X11; U; Linux armv71; Nokia N900; en-US; rv:2.0b2pre) Gecko/2010726 Namoroka/4.0b2pre Fennec/2.0a1pre
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Flags: in-litmus?
(Reporter)

Comment 5

7 years ago
I'm reassigning this to myself for adding litmus testcases for this (aakashd
discussed this on irc with blassey and ted on #mobile).
Assignee: 21 → martijn.martijn
(Reporter)

Updated

7 years ago
Assignee: martijn.martijn → 21
Flags: in-litmus? → in-litmus?(martijn.martijn)
(Reporter)

Updated

2 years ago
Flags: in-litmus?(martijn.martijn)
You need to log in before you can comment on or make changes to this bug.