572838 - Style improvements to versions page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[Justin Scott [:fligtar]]

Attachment: mock

Jeff asked me what style improvements I want made to the versions page, so made a few quick Firebug tweaks:

* the warning box should be white with a C63717 border (ignore the light blue in the screenshot)
* the padding/min-height on the h2 should be removed and it should be C63717 and italic (Jeff is making the capitalization changes)
* the giant background icon should go away
* the "Works with" label in each box should be dropped to 1em

Comment 1

[Jeff Balogh (:jbalogh)]

This affects https://preview.addons.mozilla.org/en-US/firefox/addon/1865/#releasenotes and https://preview.addons.mozilla.org/z/en-US/firefox/addon/1865/versions.

We're going for something close to the look of these sections on prod.

* The button needs to float right.
* The heading should be on one line.
* There's some stray margins and borders.

The style of the title changed in #releasenotes, but I (personally) don't mind the look.

Thanks potch!

Comment 2

[Potch [:potch]]

fligtar liked it! http://github.com/jbalogh/zamboni/commit/5f76cb5

Comment 3

[Jeff Balogh (:jbalogh)]

The new style doesn't scale: https://preview.addons.mozilla.org/z/en-US/firefox/addon/722/versions/

Comment 4

[Potch [:potch]]

much better. http://github.com/jbalogh/zamboni/commit/897c23d

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Fligtar, you made a few comments yesterday in IRC; have they been addressed?  Can you list them here, if not?

Comment 6

[Justin Scott [:fligtar]]

No, doesn't look like they've been added yet.

* release notes on the details page shouldn't be italic
* View All Versions should become 'View all versions' and have a dotted separate above it with an arrow, like 'See all reviews' has.
* the 'What's this?' link should be smaller font size like in remora
* The colon from compatibility ranges should be removed

Comment 7

[Potch [:potch]]

(In reply to comment #6)
> * The colon from compatibility ranges should be removed

Jeff, I've been looking around in the code, and I couldn't find where the formatting for the compatibility entries is located. Can you point me in the right direction, or if it's too tricky, remove the colon?

Comment 8

[Potch [:potch]]

http://github.com/jbalogh/zamboni/commit/9104366

Comment 9

[krupa raj[:krupa]]

verified the following for https://preview.addons.mozilla.org/en-US/firefox/addon/1865/

* the warning box should be white with a C63717 border 
* the padding/min-height on the h2 should be removed and it should be C63717
and italic 
* the giant background icon should go away
release notes on the details page shouldn't be italic
* View All Versions should become 'View all versions' and have a dotted
separate above it with an arrow, like 'See all reviews' has.
* the 'What's this?' link should be smaller font size like in remora
* The colon from compatibility ranges should be removed