If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Style improvements to versions page

VERIFIED FIXED in 5.11.2

Status

addons.mozilla.org Graveyard
Public Pages
P3
normal
VERIFIED FIXED
7 years ago
2 years ago

People

(Reporter: fligtar, Assigned: potch)

Tracking

Dependency tree / graph

Details

(Whiteboard: [z], URL)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Created attachment 452051 [details]
mock

Jeff asked me what style improvements I want made to the versions page, so made a few quick Firebug tweaks:

* the warning box should be white with a C63717 border (ignore the light blue in the screenshot)
* the padding/min-height on the h2 should be removed and it should be C63717 and italic (Jeff is making the capitalization changes)
* the giant background icon should go away
* the "Works with" label in each box should be dropped to 1em
This affects https://preview.addons.mozilla.org/en-US/firefox/addon/1865/#releasenotes and https://preview.addons.mozilla.org/z/en-US/firefox/addon/1865/versions.

We're going for something close to the look of these sections on prod.

* The button needs to float right.
* The heading should be on one line.
* There's some stray margins and borders.

The style of the title changed in #releasenotes, but I (personally) don't mind the look.

Thanks potch!
(Assignee)

Comment 2

7 years ago
fligtar liked it! http://github.com/jbalogh/zamboni/commit/5f76cb5
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
The new style doesn't scale: https://preview.addons.mozilla.org/z/en-US/firefox/addon/722/versions/
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

7 years ago
much better. http://github.com/jbalogh/zamboni/commit/897c23d
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
Fligtar, you made a few comments yesterday in IRC; have they been addressed?  Can you list them here, if not?
(Reporter)

Comment 6

7 years ago
No, doesn't look like they've been added yet.

* release notes on the details page shouldn't be italic
* View All Versions should become 'View all versions' and have a dotted separate above it with an arrow, like 'See all reviews' has.
* the 'What's this?' link should be smaller font size like in remora
* The colon from compatibility ranges should be removed
(Assignee)

Comment 7

7 years ago
(In reply to comment #6)
> * The colon from compatibility ranges should be removed

Jeff, I've been looking around in the code, and I couldn't find where the formatting for the compatibility entries is located. Can you point me in the right direction, or if it's too tricky, remove the colon?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

7 years ago
http://github.com/jbalogh/zamboni/commit/9104366
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED

Comment 9

7 years ago
verified the following for https://preview.addons.mozilla.org/en-US/firefox/addon/1865/

* the warning box should be white with a C63717 border 
* the padding/min-height on the h2 should be removed and it should be C63717
and italic 
* the giant background icon should go away
release notes on the details page shouldn't be italic
* View All Versions should become 'View all versions' and have a dotted
separate above it with an arrow, like 'See all reviews' has.
* the 'What's this?' link should be smaller font size like in remora
* The colon from compatibility ranges should be removed
Status: RESOLVED → VERIFIED

Updated

7 years ago
Blocks: 573901

Updated

7 years ago
Blocks: 573903

Updated

7 years ago
No longer blocks: 573903

Updated

7 years ago
Blocks: 574072
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.