572840 - Update Mozmill test templates for coding styles

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As discussed via email we want to move forward and change our licensing for test files from the Mozilla Public License to the Public Domain license.

The upcoming patch will make those changes for the template files in our repository.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

It also fixes some coding conventions we were a bit laxly in the past. It's really something which we should use from now on in our new tests and fix in existing tests once we have to modify those:

* Constants have to be declared with capital letters
* Opening brackets for functions have to be placed in the same line
* We don't need gDelay anymore.
* Module inclusion should be done via constants

Anything else I missed or which needs to be improved?

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1.1

Now without the changes to the DownloadManagerClosed test.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on all branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/34fdd1965a1d
http://hg.mozilla.org/qa/mozmill-tests/rev/3db52d993829
http://hg.mozilla.org/qa/mozmill-tests/rev/fa3cba61a286

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We want to revert that change and go back to the MPL. Patch upcoming.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Reverting to MPL

Comment 6

[u279076]

Comment on attachment 455270 [details] [diff] [review]
Reverting to MPL

>+ * The Initial Developer of the Original Code is
>+ * John Doe <[e-mail]>.
>+ *
>+ * Portions created by the Initial Developer are Copyright (C) 2010
>+ * the Initial Developer. All Rights Reserved.
>+ *
>+ * Contributor(s):
>+ *
>+ * Alternatively, the contents of this file may be used under the terms of
Would it be at all possible to add an example Contributor like we have under Initial Developer?

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #6)
> Would it be at all possible to add an example Contributor like we have under
> Initial Developer?

For a template it wouldn't be necessary because it has always to be removed. But lets discuss that next week what's possible.

Landed changes on all branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/f2cc3bc2659e
http://hg.mozilla.org/qa/mozmill-tests/rev/f1800d0c29a1
http://hg.mozilla.org/qa/mozmill-tests/rev/f6b1814ebb7b