Closed Bug 572879 Opened 12 years ago Closed 12 years ago

Narcissus JS shell

Categories

(Other Applications Graveyard :: Narcissus, defect)

Other Branch
x86
macOS
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: taustin, Assigned: taustin)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(3 files)

Currently, there is no shell for Narcissus, which would be useful for integrating with jstests.py (and possibly other tools).
Keywords: narcissus
This patch allows narcissus to be used from the command line and integrate with the jstests.py setup.
This patch removes an unnecessary file + updates testing instructions accordingly.  Also, adds a few new tests to narcFailuresFull.txt.
The shell currently relies on js.js being able to load the other files.  This patch will instead load the other js files directly (and not bother with js.js).
Attachment #452937 - Flags: review?(gal)
Attachment #453596 - Flags: review?(gal)
Attachment #454093 - Flags: review?(gal)
Comment on attachment 452937 [details] [diff] [review]
Patch for narcissus shell to use with jstests.py

>-    print: print, version: null
>+    print: print //, version: null

function() { return 185; } or whatever the JS engine does.

>+++ b/js/src/tests/narcFailures.txt	Mon Jun 21 17:25:43 2010 -0700

This ain't DOS. We can call it narcissusFailures.txt :)

I am ok with the list but we should work through this to shorten it.
Attachment #452937 - Flags: review?(gal) → review+
Attachment #453596 - Flags: review?(gal) → review+
Comment on attachment 454093 [details] [diff] [review]
Work around for lack of special 'evaluate' method.

nshell maybe?
Attachment #454093 - Flags: review?(gal) → review+
narcissus-failures.txt please -- no shift RSI, consistent with earlier failures file names.

nshell is no good -- njs?

/be
yeah, njs sounds pretty good.
Same here. Please do the changes I pointed out and the ones brendan remarked and then push the patch citing the bug # and me as reviewer.
Assignee: general → taustin
Whiteboard: fixed-in-tracemonkey
Component: JavaScript Engine → Narcissus
Keywords: narcissus
Product: Core → Other Applications
QA Contact: general → narcissus
http://hg.mozilla.org/mozilla-central/rev/566555927784
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.