If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Status

Other Applications
Narcissus
--
minor
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Tom Austin, Assigned: Tom Austin)

Tracking

Other Branch
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(3 attachments)

(Assignee)

Description

7 years ago
Currently, there is no shell for Narcissus, which would be useful for integrating with jstests.py (and possibly other tools).
(Assignee)

Updated

7 years ago
Keywords: narcissus
(Assignee)

Comment 1

7 years ago
Created attachment 452937 [details] [diff] [review]
Patch for narcissus shell to use with jstests.py

This patch allows narcissus to be used from the command line and integrate with the jstests.py setup.
(Assignee)

Comment 2

7 years ago
Created attachment 453596 [details] [diff] [review]
Some tweaks to the testing setup

This patch removes an unnecessary file + updates testing instructions accordingly.  Also, adds a few new tests to narcFailuresFull.txt.
(Assignee)

Comment 3

7 years ago
Created attachment 454093 [details] [diff] [review]
Work around for lack of special 'evaluate' method.

The shell currently relies on js.js being able to load the other files.  This patch will instead load the other js files directly (and not bother with js.js).
(Assignee)

Updated

7 years ago
Attachment #452937 - Flags: review?(gal)
(Assignee)

Updated

7 years ago
Attachment #453596 - Flags: review?(gal)
(Assignee)

Updated

7 years ago
Attachment #454093 - Flags: review?(gal)

Comment 4

7 years ago
Comment on attachment 452937 [details] [diff] [review]
Patch for narcissus shell to use with jstests.py

>-    print: print, version: null
>+    print: print //, version: null

function() { return 185; } or whatever the JS engine does.

>+++ b/js/src/tests/narcFailures.txt	Mon Jun 21 17:25:43 2010 -0700

This ain't DOS. We can call it narcissusFailures.txt :)

I am ok with the list but we should work through this to shorten it.
Attachment #452937 - Flags: review?(gal) → review+

Updated

7 years ago
Attachment #453596 - Flags: review?(gal) → review+

Comment 5

7 years ago
Comment on attachment 454093 [details] [diff] [review]
Work around for lack of special 'evaluate' method.

nshell maybe?
Attachment #454093 - Flags: review?(gal) → review+
narcissus-failures.txt please -- no shift RSI, consistent with earlier failures file names.

nshell is no good -- njs?

/be

Comment 7

7 years ago
yeah, njs sounds pretty good.

Comment 8

7 years ago
Same here. Please do the changes I pointed out and the ones brendan remarked and then push the patch citing the bug # and me as reviewer.
(Assignee)

Comment 9

7 years ago
Changeset:  http://hg.mozilla.org/tracemonkey/rev/566555927784
(Assignee)

Updated

7 years ago
Assignee: general → taustin
Whiteboard: fixed-in-tracemonkey

Updated

7 years ago
Component: JavaScript Engine → Narcissus
Keywords: narcissus
Product: Core → Other Applications
QA Contact: general → narcissus

Comment 10

7 years ago
http://hg.mozilla.org/mozilla-central/rev/566555927784
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.