572917 - Non-ASCII feedback makes the Input site ☹

Status: VERIFIED FIXED

(Input :: General, defect, P1)

Description

[Jesse Ruderman]

I tried to submit "I ♥ unicode"

I got:

Internal Server Error

An unhandled error occurred in the application. The error has been logged and an administrator was notified. We apologize for the inconvenience!

Please start over on the dashboard.

If you have additional information how to reproduce this problem, please file a bug. Thanks!

Comment 1

[Fred Wenzel [:wenzel]]

Sorry for changing priorities, but that's actually pretty major. Unicode shouldn't make it choke, thanks for finding this, Jesse.

The traceback I was emailed is:

...
  File "/usr/lib/python2.6/site-packages/MySQLdb/cursors.py", line 173, in execute
    self.errorhandler(self, exc, value)

  File "/usr/lib/python2.6/site-packages/MySQLdb/connections.py", line 36, in defaulterrorhandler
    raise errorclass, errorvalue

OperationalError: (1267, "Illegal mix of collations (latin1_swedish_ci,IMPLICIT) and (utf8_general_ci,COERCIBLE) for operation '='")

That smells like a database problem.

Fox2mike, can you tell me if our database is latin1 at the moment? We need the database itself as well as all tables to be utf-8.

Comment 2

[Shyam Mani [:fox2mike]]

Fred,

mysql> show create table auth_group;
+------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Table      | Create Table                                                                                                                                                                                  |
+------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| auth_group | CREATE TABLE `auth_group` (
  `id` int(11) NOT NULL auto_increment,
  `name` varchar(80) NOT NULL,
  PRIMARY KEY  (`id`),
  UNIQUE KEY `name` (`name`)
) ENGINE=InnoDB DEFAULT CHARSET=latin1 | 
+------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.02 sec)

Looks like syncdb didn't specify utf-8?

Comment 3

[Fred Wenzel [:wenzel]]

It's true, syncdb does not specify anything. I think if you create the db as utf-8 in the first place it just magically works.

Added utf-8 to the default settings: http://github.com/fwenzel/reporter/commit/b9a9f5f

And Shyam switched our databases/tables to utf-8. Submitting unicode in feedback works now, I tried with the example from comment 0.

Thanks!

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED!

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Added Litmus test #15061

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Submitted pull request with automated test (https://github.com/mozilla/input-tests/pull/20), however it will be disabled until we are running tests in the latest Firefox beta.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #6)
> Submitted pull request with automated test
> (https://github.com/mozilla/input-tests/pull/20), however it will be disabled
> until we are running tests in the latest Firefox beta.

<3; thanks as always, Dave!

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Selenium test is now in the main test repository.