Closed
Bug 572960
Opened 14 years ago
Closed 14 years ago
Only run the InstallTrigger callback on success
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
5.11.3
People
(Reporter: jbalogh, Assigned: potch)
References
()
Details
(Whiteboard: [z][button])
Thus spoke Mossop: The callback function gets passed two arguments. First is the url of the xpi it is calling for, second is a status code: http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/addonManager.js#52 You probably only want to redirect if the status was 0.
Updated•14 years ago
|
Assignee: nobody → thepotch
Comment 1•14 years ago
|
||
-> potch, r? jbalogh since he likes the buttons so much
Assignee | ||
Comment 2•14 years ago
|
||
http://github.com/jbalogh/zamboni/commit/02977f3c
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 3•14 years ago
|
||
What's the best way to verify this? With Firebug, I'm guessing, but how?
Reporter | ||
Comment 4•14 years ago
|
||
1. Find an addon that redirects to contributions after installation. 2. Install it and see that you are redirected. 3. Uninstall. 4. Click add to firefox but cancel installation. You should not be redirected and there should be no js errors.
Comment 5•14 years ago
|
||
I cancelled installation through the Add-ons Manager, and was redirected to https://preview.addons.mozilla.org/z/en-US/firefox/addon/25/developers; reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Reporter | ||
Comment 6•14 years ago
|
||
(In reply to comment #5) > I cancelled installation through the Add-ons Manager, and was redirected to > https://preview.addons.mozilla.org/z/en-US/firefox/addon/25/developers; > reopening. Wrong kind of cancel. I'm talking about cancelling after the 3-second countdown. Once it's in about:addons we're totally disconnected.
Comment 7•14 years ago
|
||
Potch/Jeff: re-close at will, sires!
Reporter | ||
Updated•14 years ago
|
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•