This is a regression from the new add-ons manager
Do we want to take the opportunity in Firefox 4 to kill the callback function? If the functionality is really really wanted we could fire events at the page and let people write listeners for it. That seems more "webby" to me.
(In reply to comment #2) > Do we want to take the opportunity in Firefox 4 to kill the callback function? > If the functionality is really really wanted we could fire events at the page > and let people write listeners for it. That seems more "webby" to me. If someone contributed a patch to do that then I think we would take it, otherwise I don't think we have the time left to do it. I'd rather roll that out very early in the cycle of a future release to give people as much time to update as possible.
Comment on attachment 452178 [details] [diff] [review] testcase Once bug 550936 is fixed I'd like to land this testcase to make sure we don't regress. The code change also adds nicer error console reporting when the callback function in the webpage throws an exception.
Attachment #452178 - Flags: review?(robert.bugzilla)
8 years ago
Attachment #452178 - Flags: review?(robert.bugzilla) → review+
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b5
Dave, is there a way to manually verify the fix or do we have to trust the automated test?
Testing the fix would require a page with a callback that attempts to redirect to a relate url. The one in the test case could be adjusted for a manual test, I'm not sure there is a lot to be gained from that though.
Ok, so our automated test should be enough then. Since QA cannot test it in a manual way I will mark it verified fixed based on the passing automated test.
You need to log in before you can comment on or make changes to this bug.