Closed Bug 572968 Opened 15 years ago Closed 15 years ago

Avoid XGetGeometry round trip creating (foreign) GdkPixmaps for gfxXlibSurfaces

Categories

(Core :: Graphics, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b1

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(1 file)

With retained layers (bug 564991) we'll be drawing to surfaces that don't come from GdkPixmaps as provided by this code: http://hg.mozilla.org/mozilla-central/annotate/5f3955a452ac/widget/src/gtk2/nsWindow.cpp#l2381 Drawing native themes then needs a GdkPixmap but gdk_pixmap_foreign_new_for_display() needs a round-trip in XGetGeometry. This can be avoided by instead passing the geometry to gdk_pixmap_foreign_new_for_screen(), which is available from GTK+-2.10, our minimum supported version. https://wiki.mozilla.org/Linux/Runtime_Requirements
Attachment #452180 - Flags: review? → review?(jmuizelaar)
Comment on attachment 452180 [details] [diff] [review] use gdk_pixmap_foreign_new_for_screen There's some inconsistency with returning nsnull and NULL
Attachment #452180 - Flags: review?(jmuizelaar) → review+
Landed with no nsnulls for GdkWindows. http://hg.mozilla.org/mozilla-central/rev/7b667496a969
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a6
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: