572981 - building Firefox with extensions disabled causes installer (dmg) creation to fail

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[Josh Aas]

If you build Firefox with extensions disabled (ac_add_options --disable-extensions) the installer creation will fail with the following error:

processing /Users/josh/src/mozilla/ff_4_opt/toolkit/locales/jar.mn
cat /Users/josh/src/mozilla/ff_4_opt/toolkit/locales/update.locale | sed -e "s/%AB_CD%/en-US/" > ../../dist/xpi-stage/locale-en-US/update.locale
make[4]: Leaving directory `/Users/josh/src/mozilla/ff_4_opt/objdir-opt/toolkit/locales'
make[3]: Leaving directory `/Users/josh/src/mozilla/ff_4_opt/objdir-opt/toolkit/locales'
make: Entering an unknown directory
make: *** ../../extensions/reporter/locales: No such file or directory.  Stop.
make: Leaving an unknown directory
make[2]: *** [libs-en-US] Error 2
make[2]: Leaving directory `/Users/josh/src/mozilla/ff_4_opt/objdir-opt/browser/locales'
make[1]: *** [libs] Error 2
make[1]: Leaving directory `/Users/josh/src/mozilla/ff_4_opt/objdir-opt/browser/installer'
make: *** [default] Error 2
make: Leaving directory `/Users/josh/src/mozilla/ff_4_opt/objdir-opt/browser/installer'

Comment 1

[(not currently active) Ted Mielczarek]

This is probably because --disable-extensions just means "don't build anything from the extensions/ directory", and that's where reporter happens to live. See also bug 536237.

Comment 2

[Jamal]

(In reply to comment #0)
> If you build Firefox with extensions disabled (ac_add_options
> --disable-extensions) the installer creation will fail with the following
> error:
> 
> processing /Users/josh/src/mozilla/ff_4_opt/toolkit/locales/jar.mn
> cat /Users/josh/src/mozilla/ff_4_opt/toolkit/locales/update.locale | sed -e
> "s/%AB_CD%/en-US/" > ../../dist/xpi-stage/locale-en-US/update.locale
> make[4]: Leaving directory
> `/Users/josh/src/mozilla/ff_4_opt/objdir-opt/toolkit/locales'
> make[3]: Leaving directory
> `/Users/josh/src/mozilla/ff_4_opt/objdir-opt/toolkit/locales'
> make: Entering an unknown directory
> make: *** ../../extensions/reporter/locales: No such file or directory.  Stop.
> make: Leaving an unknown directory
> make[2]: *** [libs-en-US] Error 2
> make[2]: Leaving directory
> `/Users/josh/src/mozilla/ff_4_opt/objdir-opt/browser/locales'
> make[1]: *** [libs] Error 2
> make[1]: Leaving directory
> `/Users/josh/src/mozilla/ff_4_opt/objdir-opt/browser/installer'
> make: *** [default] Error 2
> make: Leaving directory
> `/Users/josh/src/mozilla/ff_4_opt/objdir-opt/browser/installer'

Comment 3

[Benjamin Smedberg]

Yep, just don't do that.