572994 - Allow reading of complex preferences to retrieve the default homepage

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

In the last weeks we had a couple of situation when we failed to load the home page. Mainly those problems happened on Ubuntu due to the installed Ubufox extension.

Today I digged into this problem and checked possible solutions how to reliable retrieve the home page url. It has taken quite a while but now I'm sure we are on the right track. The solution is not to manually parse a properties file when reading the browser.startup.homepage pref, but simply to use the getComplexValue function from the nsIPrefBranch service.

I did some tests with the patch, which I will attach in a couple of seconds, and everything looks fine.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Please test this patch as intensely as you can. I wasn't able to see a regression.

Comment 2

[u279076]

Comment on attachment 452217 [details] [diff] [review]
Patch v1

Codewise this is good and does not cause regressions, so r+.  However, this does not solve this issue reported in bug 572786.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v2

(In reply to comment #2)
> (From update of attachment 452217 [details] [diff] [review])
> Codewise this is good and does not cause regressions, so r+.  However, this
> does not solve this issue reported in bug 572786.

You are right and we have discussed that in a pm. So the solution we really need, and that getDefaultHompage() should do, is to query the defaultBranch. Only this branch will contain the original values.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v2.1

Now without modifications to the test file.

Comment 5

[u279076]

This resolves the issue on bug 572786. r+

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on all branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/c4f6361d0fb6
http://hg.mozilla.org/qa/mozmill-tests/rev/b7c166ce7b96
http://hg.mozilla.org/qa/mozmill-tests/rev/d11b8b3665b7

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I had to check-in a bustage fix for testGeolocation.js. It's the only test which was using PrefsAPI.preferences.branch and I forgot to change.

http://hg.mozilla.org/qa/mozmill-tests/rev/1c70006a0280
http://hg.mozilla.org/qa/mozmill-tests/rev/c81531fde515
http://hg.mozilla.org/qa/mozmill-tests/rev/4311c24c33a4

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.