573004 - jsctypes-test: test_closure_cdecl is mangled

Status: RESOLVED FIXED

(Core :: js-ctypes, defect)

Description

[Ginn Chen]

With Sun Studio compiler, test_closure_cdecl() doesn't match the declaration in header.
extern "C" functor vs. no extern "C" functor.

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[[e-mail]]

I don't get it.

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/ctypes/tests/jsctypes-test.h#191

All the other functions are declared in the 'extern C' block in the header, and inherit that linkage when defined in the cpp. Why is this function different?

If this is a bug in the Sun compiler, I'd suggest wrapping everything in the cpp in NS_EXTERN_C, to keep things consistent and unsurprising.

Comment 3

[[e-mail]]

Also, I'm curious how it's mangled. What's the symbol name?

Comment 4

[Ginn Chen]

The mangled name is __1cStest_closure_cdecl6FWpFW_i_i_

Other functions don't use function pointer as a parameter. so ...

A cleaner solution would be using typedef for the functor.

Since it is only a test program, and the functor is only used here, I thought it might not be necessary.

Comment 5

[[e-mail]]

Ah, got it. Anonymous function type. Yeah, let's typedef it.

Comment 6

[Ginn Chen]

Attachment: patch v2

Comment 7

[[e-mail]]

Comment on attachment 453688 [details] [diff] [review]
patch v2

>diff --git a/toolkit/components/ctypes/tests/jsctypes-test.cpp b/toolkit/components/ctypes/tests/jsctypes-test.cpp

> #if defined(_WIN32) && !defined(_WIN64)
> PRInt32
> test_closure_cdecl(PRInt8 i, PRInt32 (NS_STDCALL *f)(PRInt8))
> {

Can you also typedef this pointer? Perhaps call it test_func_ptr_stdcall.

>diff --git a/toolkit/components/ctypes/tests/jsctypes-test.h b/toolkit/components/ctypes/tests/jsctypes-test.h

> #if defined(_WIN32) && !defined(_WIN64)
>   NS_EXPORT PRInt32 test_closure_stdcall(PRInt8, PRInt32 (NS_STDCALL *)(PRInt8));
> #endif /* defined(_WIN32) && !defined(_WIN64) */

(Declared here. Note: the declaration will have to be inside the #ifdef.)

Thanks! r=dwitte.

Comment 8

[Ginn Chen]

http://hg.mozilla.org/mozilla-central/rev/234a06c6aab6