Closed Bug 573087 Opened 14 years ago Closed 14 years ago

Automangle ctypes stdcall symbols

Categories

(Core :: js-ctypes, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
blocking2.0 --- beta4+

People

(Reporter: dwitte, Assigned: dwitte)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

On Windows, the symbol names for stdcall functions end up looking like:

  _myfun@40

Where '40' is the (padded) net size of the arguments.

We should automangle this so that, instead of figuring out that nonsense, the user can just declare it as "myfun".
This should block Fx4 since it's a significant API change.
blocking2.0: --- → ?
Attached patch patch v1Splinter Review
Pretty self-explanatory. This passes tests on WIN32 for me... which is the strongest indicator that the argsize logic is correct. (The various C test functions exercise the combinations pretty well!)
Assignee: nobody → dwitte
Status: NEW → ASSIGNED
Attachment #459617 - Flags: review?(benjamin)
Attachment #459617 - Flags: review?(benjamin) → review+
blocking2.0: ? → beta4+
http://hg.mozilla.org/tracemonkey/rev/bd38a23c5f41
Whiteboard: fixed-in-tracemonkey
Blocks: 585175
http://hg.mozilla.org/mozilla-central/rev/bd38a23c5f41
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: