Automangle ctypes stdcall symbols

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dwitte, Assigned: dwitte)

Tracking

unspecified
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking2.0 beta4+)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

On Windows, the symbol names for stdcall functions end up looking like:

  _myfun@40

Where '40' is the (padded) net size of the arguments.

We should automangle this so that, instead of figuring out that nonsense, the user can just declare it as "myfun".
This should block Fx4 since it's a significant API change.
blocking2.0: --- → ?
Posted patch patch v1Splinter Review
Pretty self-explanatory. This passes tests on WIN32 for me... which is the strongest indicator that the argsize logic is correct. (The various C test functions exercise the combinations pretty well!)
Assignee: nobody → dwitte
Status: NEW → ASSIGNED
Attachment #459617 - Flags: review?(benjamin)
Attachment #459617 - Flags: review?(benjamin) → review+
blocking2.0: ? → beta4+
http://hg.mozilla.org/tracemonkey/rev/bd38a23c5f41
Whiteboard: fixed-in-tracemonkey
Blocks: 585175
http://hg.mozilla.org/mozilla-central/rev/bd38a23c5f41
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.