Closed
Bug 573177
Opened 15 years ago
Closed 15 years ago
buildbot: AggregateMailNotifier does not work when there is only a single builder
Categories
(Tamarin Graveyard :: Tools, defect)
Tamarin Graveyard
Tools
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: cpeyer, Assigned: cpeyer)
Details
Attachments
(1 file)
3.72 KB,
patch
|
brbaker
:
review+
jsudduth
:
review+
|
Details | Diff | Splinter Review |
Found this while testing locally with a single builder. The buildFinished method assumes that there will be more than one builder per builderGroup, therefore the logic to check whether the buildGroup is finished is imbedded within the second builder check.
Assignee | ||
Comment 1•15 years ago
|
||
Fix the issue by moving the builder-finished logic out of the "builderGroup.currentBuild == revision" block. Also added some minor comments.
Updated•15 years ago
|
Attachment #452394 -
Flags: review?(jsudduth)
Comment 2•15 years ago
|
||
Comment on attachment 452394 [details] [diff] [review]
fix single builder case
patch pushed changeset - 4840:cda4fe1085ce
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Attachment #452394 -
Flags: review?(brbaker) → review+
Assignee | ||
Updated•14 years ago
|
Status: RESOLVED → VERIFIED
Updated•14 years ago
|
Attachment #452394 -
Flags: review?(jsudduth) → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•