Closed Bug 573177 Opened 15 years ago Closed 15 years ago

buildbot: AggregateMailNotifier does not work when there is only a single builder

Categories

(Tamarin Graveyard :: Tools, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: cpeyer, Assigned: cpeyer)

Details

Attachments

(1 file)

Found this while testing locally with a single builder. The buildFinished method assumes that there will be more than one builder per builderGroup, therefore the logic to check whether the buildGroup is finished is imbedded within the second builder check.
Fix the issue by moving the builder-finished logic out of the "builderGroup.currentBuild == revision" block. Also added some minor comments.
Assignee: nobody → cpeyer
Status: NEW → ASSIGNED
Attachment #452394 - Flags: review?(brbaker)
Attachment #452394 - Flags: review?(jsudduth)
Comment on attachment 452394 [details] [diff] [review] fix single builder case patch pushed changeset - 4840:cda4fe1085ce
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #452394 - Flags: review?(brbaker) → review+
Status: RESOLVED → VERIFIED
Attachment #452394 - Flags: review?(jsudduth) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: