573300 - Move the sending of email notifications to Bugzilla::Bug

Status: NEW

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[David Lawrence [:dkl]]

In bug 413215, Bugzilla::BugMail::SendMail in process_bug.cgi was moved the Bugzilla::Bug::send_changes so that other scripts can take advantage of the
additional notifications sent out by process_bug.cgi such as dependencies and notifying users removed from a bug. Other code that uses Bugzilla::BugMail::Send should also start using Bugzilla::Bug::send_changes as well for the same benefits. The places where the changes should occur are:

post_bug.cgi
attachment.cgi
extensions/Voting/Extension.pm
Bugzilla/WebService/Bug.pm (create(), add_comment(), update_see_also())
editusers.cgi

and maybe others. send_changes() can take a $changes variable to look for changes such as removed users related to the bug. But even without that it
can still be useful to other code.

Comment 1

[Frédéric Buclin]

editusers.cgi is unrelated to bugs, AFAIK.

Comment 2

[David Lawrence [:dkl]]

(In reply to comment #1)
> editusers.cgi is unrelated to bugs, AFAIK.

Thanks for changing the subject. I cloned it and forgot to myself.

As for editusers.cgi, it send bug emails when a user is removed and it has to reassign that user's bugs to the default owners for a component.

Dave

Comment 3

[Frédéric Buclin]

Wow, I didn't remember we were doing this. IMO, we shouldn't. As for all other admin tasks, this should be done silently.

Comment 4

[David Lawrence [:dkl]]

Ok, but editusers.cgi is adding a bugs_activity entry to the bug users will eventually see the changes next time a different change is made. Unless we update the last diffed value for each bug to the current timesramp in editusers.cgi.

Dave