573309 - [SeaMonkey] Mochitest-4 leaked 360 bytes during test execution

Status: RESOLVED FIXED

(SeaMonkey :: Testing Infrastructure, defect)

Description

[Justin Wood (:Callek)]

This is a new leak in SeaMonkey, range is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=88fa0b783306&tochange=41bdc98c32bd

With c-c checkin http://hg.mozilla.org/comm-central/rev/ff4b8b04a116

Out of that pushlog my largest suspect is http://hg.mozilla.org/mozilla-central/rev/1a575a9ad94f which was mrbkap's change merged down and pushed by sayre from TM.

-----

== BloatView: ALL (cumulative) LEAK AND BLOAT STATISTICS

     |<----------------Class--------------->|<-----Bytes------>|<----------------Objects---------------->|<--------------References-------------->|
                                              Per-Inst   Leaked    Total      Rem      Mean       StdDev     Total      Rem      Mean       StdDev
   0 TOTAL                                          20      360 1111422019       15 (40440.02 +/- 26621.96) 478899449       15 (17225.08 +/- 25238.62)
 176 jsdScript                                      56      280        5        5 (    3.00 +/-     1.58)       20        5 (    8.86 +/-     4.07)
 857 nsStringBuffer                                  8       80  6614430       10 (33319.36 +/-  3380.41) 15944091       10 (38627.78 +/-  3516.58)

nsTraceRefcntImpl::DumpStatistics: 1054 entries
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 360 bytes during test execution
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 5 instances of jsdScript with size 56 bytes each (280 bytes total)
TEST-UNEXPECTED-FAIL | automationutils.processLeakLog() | leaked 10 instances of nsStringBuffer with size 8 bytes each (80 bytes total)

Comment 1

[Robert Kaiser]

mrbkap:
Is it possible that patch for bug 572149 triggered this leak? Note that SeaMonkey right now probably always runs with jsd enabled, as we have venkman loaded and activated in all our builds and venkman enables jsd on app startup to be able to debug all the app's scripts.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

No. If you hit the newly added code then you would have already been crashing.

Comment 3

[Robert Kaiser]

Callek, I think this one is gone, right?

Comment 4

[Justin Wood (:Callek)]

Not certain, it existed when venkman was enabled, before XPCOM changes. and I haven't had a chance to look since it was re-enabled.

Especially with our other leak masking this even IF it does exist. I wanted to keep this open until then to verify.

Comment 5

[Robert Kaiser]

Well, mochitest-plain-4 is green, without leaks (well, except the Linux thing of bug 585438, which makes us not have data there - but our leaks is cross-platform).

Comment 6

[Robert Kaiser]

Let's mark it fixed then, after some IRC discussion. With the Linux exception, mochitest-plain-4 is the only green test right now, so no need to keep a report open against it.