573378 - uptime does not sort numerically

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Wayne Mery (:wsmwk)]

https://crash-stats.mozilla.com/report/list?version=Thunderbird%3A3.0.5&build_id=&query_search=signature&query_type=exact&query=&date=2010-06-20%2008%3A00%3A00&range_value=4&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=&signature=nsQueryInterface%3A%3Aoperator%28%29%28nsID%20const%26%2C%20void**%29&missing_sig=&page=1

click uptime 
get ordering like
1
10
116
14
17725
189
2
2
22586

Comment 1

[Wayne Mery (:wsmwk)]

p.s. I could swear this was working fine a few days ago

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

From the closed bugs (https://bugzilla.mozilla.org/buglist.cgi?chfieldto=Now&query_format=advanced&chfieldfrom=2010-04-01&short_desc=sort&bug_status=RESOLVED&bug_status=VERIFIED&short_desc_type=allwordssubstr&component=Socorro&product=Webtools), it looks like Ryan fixed most of the existing sort bugs for 1.7 (but bug 564088 missed the cut, as apparently did this column).

Comment 3

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Thanks guys, I'll take a look.  I can reproduce the error on stage, but haven't been able to reproduce it in my sandbox yet.  I'll keep poking at it.

Comment 4

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Attachment: Patch 1 for 573378

1. Forcing column 9 Uptime to sort numerically
2. Fixed auto-sort, which was auto-sorting on the Uptime field instead of the Comments field.  The addition of the Hang column shifted the Comments field 1 column to the right (column 9 instead of column 10).
3. Fixed nav problems in sandboxes from */report* pages

Comment 5

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Thanks Laura.  Committing.  Wayne and/or Smokey, could you please test this fix on stage?  The changes should appear there by 2:15pm PST.  Thanks!

==

Sending        webapp-php/application/controllers/report.php
Sending        webapp-php/js/socorro/report_list.js
Transmitting file data ..
Committed revision 2161.

Comment 6

[Wayne Mery (:wsmwk)]

looks good at http://crash-stats.stage.mozilla.com/report/list?range_value=2&range_unit=weeks&signature=hang%20|%20mozilla%3A%3Aipc%3A%3ARPCChannel%3A%3ACall%28IPC%3A%3AMessage*%2C%20IPC%3A%3AMessage*%29&version=Firefox%3A3.6.4

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; sorting and pagination don't play nicely together (the sort option doesn't persist across pages), but that's a separate bug.

Comment 8

[Laura Thomson :laura]

Verified on prod after 1.8 release.

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to comment #8)
> Verified on prod after 1.8 release.

I agree. Thanks!

Comment 10

[Laura Thomson :laura]

Merge to 1.7.6

Comment 11

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Looks like this was fixed in 1.7.5.

Comment 12

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Oy, wrong bug ticket. Reopening.

Comment 13

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Committing fix from 1.8.

Sending        webapp-php/js/socorro/report_list.js
Transmitting file data .
Committed revision 2714.

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://crash-stats.stage.mozilla.com/report/list?version=Firefox%3A4.0b6&build_id=&query_search=signature&query_type=exact&query=&date=&range_value=2&range_unit=weeks&hang_type=any&process_type=any&plugin_field=&plugin_query_type=&plugin_query=&do_query=&signature=js_fun_apply%28JSContext*%2C%20unsigned%20int%2C%20js%3A%3AValue*%29&missing_sig=&admin=&page=1.

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot