Note: There are a few cases of duplicates in user autocompletion which are being worked on.

rights infobar not displayed any more

VERIFIED FIXED in seamonkey2.1a2

Status

SeaMonkey
Startup & Profiles
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Robert Kaiser, Assigned: neil@parkwaycc.co.uk)

Tracking

(Blocks: 1 bug)

Trunk
seamonkey2.1a2
Dependency tree / graph

Firefox Tracking Flags

(blocking-seamonkey2.1 b1+)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
As I noted in bug 508039 comment #38, bug 558664 removed the subject parameter on the observer notification for the sessionstore-windows-restored topic, and so the infobar for "Know Your Rights" isn't being displayed any more.

I found this because places bookmarks also want to display another notification on the same event if the DB locked.
(Reporter)

Comment 1

7 years ago
Ouch, the bug that caused the problem is bug 558644, actually.

IMHO the solutions here is one of:
1) Making our way from bug 508039 work again AND port it to Firefox as well so we don't re-do the bug 558644 mistake, or
2) Getting the window the Firefox way and leave the observer notification as it is.
Depends on: 558644
No longer depends on: 558664
(Assignee)

Comment 2

7 years ago
Actually it was bug 547406 but yes I completely overlooked it :-(
Depends on: 547406
No longer depends on: 558644
(Reporter)

Updated

7 years ago
blocking-seamonkey2.1: --- → ?
(Assignee)

Comment 3

7 years ago
Created attachment 452610 [details] [diff] [review]
Back out incorrect changes
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #452610 - Flags: review?(kairo)

Updated

7 years ago
blocking-seamonkey2.1: ? → b1+
(Reporter)

Updated

7 years ago
Attachment #452610 - Flags: review?(kairo) → review+
(Reporter)

Comment 4

7 years ago
Oh, in this case, we really should port this to Firefox as well, both to improve their code and to not port over the error again.

Are you willing to file a bug, possibly even a patch?
(Assignee)

Comment 5

7 years ago
Pushed changeset de79d19f1f17 to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Target Milestone: --- → seamonkey2.1a2

Updated

7 years ago
Version: unspecified → Trunk
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a6pre) Gecko/20100619 SeaMonkey/2.1a2pre
Build ID:   20100620161917

I see the infobar in a new profile. I don't expect it to work differently on W32, Mac, or L64 than it does on L32. => VERIFIED. (If someone does not see the infobar in a fresh profile in a SeaMonkey 2.1a2pre built later than comment #5, feel free to REOPEN with details of where and how.)

The fact that, in the default theme, it is the same color as the chrome makes it easy to miss, but if it is wanted to change that it would of course be a different bug.

(I wonder why the user-agent has stopped tracking the build date but that is yet another bug if desired. Maybe intentional against fingerprinting but might make bug-tracking and finding regression ranges harder.)
Status: RESOLVED → VERIFIED
(Reporter)

Updated

7 years ago
Blocks: 574645
(Reporter)

Comment 7

7 years ago
I filed bug 574645 on doing the same trick of passing the window in Firefox code.
You need to log in before you can comment on or make changes to this bug.