problem with pushlog on mozilla-1.9.2

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
--
blocker
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: nthomas, Unassigned)

Tracking

Details

(Reporter)

Description

8 years ago
Our buildbot systems think the latest change on mozilla-central is 211153ce7d84, so it queries http://hg.mozilla.org//mozilla-central/pushlog?fromchange=211153ce7d8478cca7505e8020cb52ac81b189e0
That should return e92012b73cbb.

Similarly the last try revision we heard about is 569972bdc627, and there have been half a dozen pushes since then. We're querying http://hg.mozilla.org//try/pushlog?fromchange=569972bdc6279d03de0a420caa565a0163ce1c49&tipsonly=1

So something broke after 8:30 this morning. Strangely if you s/pushlog/pushloghtml/ on those urls then you get the changes you should. Fallout from the varnish caching changes ?
(Reporter)

Comment 1

8 years ago
All trees are closed for this issue.
Assignee: server-ops → aravind
This is the problem with pushlog on releases/mozilla-1.9.2

[Sun Jun 20 16:18:49 2010] [error] [client 10.2.74.69] UnicodeDecodeError: 'ascii' codec can't decode byte 0xd9 in position 2: ordinal not in range(128)
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69] mod_wsgi (pid=1334): Exception occurred processing WSGI script '/repo/hg/webroot_wsgi/releases/hgwebdir.wsgi'.
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69] Traceback (most recent call last):
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]   File "/usr/lib64/python2.4/site-packages/mercurial/hgweb/request.py", line 139, in run_wsgi
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]     return application(env, respond)
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]   File "/usr/lib64/python2.4/site-packages/mercurial/hgweb/hgwebdir_mod.py", line 104, in __call__
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]     return self.run_wsgi(req)
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]   File "/usr/lib64/python2.4/site-packages/mercurial/hgweb/hgwebdir_mod.py", line 161, in run_wsgi
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]     return hgweb(repo).run_wsgi(req)
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]   File "/usr/lib64/python2.4/site-packages/mercurial/hgweb/hgweb_mod.py", line 190, in run_wsgi
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]     content = getattr(webcommands, cmd)(self, req, tmpl)
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]   File "/repo/hg/extensions/pushlog-feed.py", line 311, in pushlogFeed
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]     ctx = web.repo.changectx(node)
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]   File "/usr/lib64/python2.4/site-packages/mercurial/localrepo.py", line 477, in changectx
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]     return self[changeid]
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]   File "/usr/lib64/python2.4/site-packages/mercurial/localrepo.py", line 130, in __getitem__
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]     return context.changectx(self, changeid)
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]   File "/usr/lib64/python2.4/site-packages/mercurial/context.py", line 27, in __init__
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]     self._node = self._repo.lookup(changeid)
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]   File "/usr/lib64/python2.4/site-packages/mercurial/localrepo.py", line 449, in lookup
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69]     if key in self.dirstate.parents():
[Sun Jun 20 16:18:51 2010] [error] [client 10.2.74.69] UnicodeDecodeError: 'ascii' codec can't decode byte 0xd9 in position 2: ordinal not in range(128)
(Reporter)

Comment 3

8 years ago
Everything except 1.9.2 is fixed by the change to the caching rules & cache dump. Seems likely something is broken in the pushlog for 1.9.2 as these work ok
http://hg.mozilla.org/releases/mozilla-1.9.2 http://hg.mozilla.org/releases/mozilla-1.9.2/pushloghtml?fromchange=8f2a1bc1e937&tochange=497893913a7a
but this doesn't http://hg.mozilla.org/releases/mozilla-1.9.2/pushloghtml?fromchange=8f2a1bc1e937

Farm that out to a new bug ?
(Reporter)

Comment 4

8 years ago
(In reply to comment #3)
> Everything except 1.9.2 is fixed ...
I mean everything we're polling for buildbot, can't make a truly global claim there. The failing url is http://hg.mozilla.org//releases/mozilla-1.9.2/pushlog?fromchange=497893913a7a6bbbdc18c1daf3f46eaf85b8a8d0
This error is from mercurial itself, punting to Hg:Customizations.
Assignee: aravind → nobody
Component: Server Operations → Hg: Customizations
QA Contact: mrz → hg.customizations
Huh, interesting traceback. Aravind, can you debug the repr(node) of what we're passing to web.repo.changectx()?
(Reporter)

Comment 7

8 years ago
Morphing to 1.9.2 issue.
Summary: pushlog not returning recent changes (no builds are starting!) → problem with pushlog on mozilla-1.9.2
(Reporter)

Comment 8

8 years ago
(In reply to comment #1)
> All trees are closed for this issue.
(In reply to comment #7)
> Morphing to 1.9.2 issue.

Just 1.9.2 is closed at the moment.
(Reporter)

Comment 9

8 years ago
The 1.9.2 issue is the same as bug 573285, ie records getting into pushlog but not actually landing in the repo because the other hooks. Aravind cleared out the two rogue records and pushlog is back in action. Go Aravind!
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Reporter)

Comment 10

8 years ago
So to recap
* this bug started off with pushlog getting stale due to varnish caching rules; rules were relaxed, issue resolved
* pushlog on mozilla-1.9.2 was then broken because of the hook ordering issue; bogus data was removed
(Assignee)

Updated

4 years ago
Product: mozilla.org → Release Engineering
(Assignee)

Updated

3 years ago
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.