573516 - unwrap_full_update.sh returns 0 even when it fails

Status: NEW

(Firefox Build System :: General, defect)

Description

[Chris AtLee [:catlee]]

e.g.
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1277114546.1277125497.2646.gz&fulltext=1

the slave ran out of disk unpacking the previous mar file, but the step 'passed' anyway.

Comment 1

[Chris AtLee [:catlee]]

Attachment: Add 'set -e' to unwrap_full_update.sh

Comment 2

[Chris AtLee [:catlee]]

Comment on attachment 452772 [details] [diff] [review]
Add 'set -e' to unwrap_full_update.sh

Foresee any problems with this?  WFM on my laptop.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 452772 [details] [diff] [review]
Add 'set -e' to unwrap_full_update.sh

I don't know anything about this code; any particular reason you're asking me?

Comment 4

[Chris AtLee [:catlee]]

(In reply to comment #3)
> (From update of attachment 452772 [details] [diff] [review])
> I don't know anything about this code; any particular reason you're asking me?

You were the last one to touch it...in 2008.

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 452772 [details] [diff] [review]
Add 'set -e' to unwrap_full_update.sh

I guess I was the last person to touch the file, though.

I guess it looks fine to me, so r=dbaron, I suppose.