57354 - saving progress dialog should grab focus on creation

Status: VERIFIED WORKSFORME

(SeaMonkey :: UI Design, defect, P3)

Description

[Tom Everingham]

Overview Description:  When saving file to disk the progress dialog should be 
initially in focus so that I know the download has started. 

Steps to Reproduce:  
1.)  Go to url
2.)  Scroll down to nightly build and select Windows build
3.)  in helper app, select save to disk, then ok
4.)  select Save in 'Enter name of file ..'

Actual Results:  Save to disk starts but save dialog in background

Expected Results:  dialog should be on top

Build Date & Platform Bug Found:  WinNT 1019

Additional Builds and Platforms Tested On:
not seen on mac or linux

Comment 1

[Tom Everingham]

sairuh, do you think we should mark this rtm.  Kindof embarrasing bug if you 
askes me.

Comment 2

[sairuh (rarely reading bugmail)]

yeah, it looks ridiculous. but i doubt pdt will hold rtm for this... fwiw, i
also see this on win98 (using mozilla branch bits).

Comment 3

[Tom Everingham]

ok.  Noting that this also happens when downloading from an ftp directory.  1023 
build.

Comment 4

[don]

Bill, this must me a regression.  I swear this was working recently.

Comment 5

[Jason Eager]

Reworded summary.

Comment 6

[Bill Law]

Definitely a problem and I hadn't noticed it in a build from last week.  Could
be some subtle timing/focus thing.  I'll investigate.  Adding mscott to cc:
list.  Scott, if you have time to investigate this let me know; you know the
code that's opening that progress dialog and can probably figure out what's
wrong/changed faster than I.

Comment 7

[Bill Law]

Tom, Sarah: Can you check this out on Linux/Mac?  Can somebody do a quick check
of recent builds and see in which build it first appeared?

Comment 8

[Bill Law]

One other question: does the problem go away by any chance when you apply
mscott's fix for bug 58669?

I'm thinking that there's no way this is going to get rtm+[+] because it is
basically a cosmetic thing (the progress window is there, the download
completes).  Any work on this has to be coordinated with the fix for but 58669,
which makes accepting both that fix and this one riskier still.

Who can decide to mark this [rtm-]? 

Comment 9

[Tom Everingham]

doesn't happen on linux or the mac.  I checked a few old mozilla builds on my 
system and it works on my 10/07 build, doesn't work on 10/14 ... so this started 
happening between those dates.  I'm not set up to apply a patch, sorry

Comment 10

[Bill Law]

Thanks, Tom, that's good information.  It happens that I made the
"Downloading..." dialog modal with a checkin on 10/10 so maybe that exposed this
problem and mscott's fix for 58669 will fix this one, too.

I'll check that out on my NT build.

Comment 11

[Scott MacGregor]

Thanks for looking into this. Shall we mark it a dup of 58669 since that will
fix this bug?

Comment 12

[don]

Bill, if you feel that this is a dup, then mark it that way RSN.  Otherwise Phil
and I think this is a minus.

Comment 13

[Bill Law]

I don't think this is a dup of bug 58669, just a coincidence.

BTW, I verified that the fix for bug 58669 does indeed make this problem go
away; I'll note that in that bug and perhaps that will help to get that fix
accepted.

This one should be closed WFM after the fix for 58669 lands, and marked [rtm-]
till then (at least that's my theory).

Comment 14

[Bill Law]

Decided to add a "depends on" for bug 58869 to simplify getting back and forth
between these bugs (it does sort of depend on it, I guess).

Comment 15

[don]

OK, i'm marking this rtm- then.

Comment 16

[Paul Chen]

nav triage team:

Just tested using NS6 RTM, dialogs comes to foreground. Marking this bug W4M.

Comment 17

[sairuh (rarely reading bugmail)]

mass verification of WorksForMe bugs: to find all bugspam pertaining to this,
set your search string to "IfItWorksForSlappyTheSquirrelThenItWFM".

if you think this particular bug is *still* an open issue, please make sure of
the following before reopening:

a. that it's still a problem with ***recent trunk builds*** on the all
appropriate platform[s]

b. provide clear steps to reproduce (unless a good test case is already in the
bug report), making sure it pertains to the original problem (avoid morphing as
much as possible :)