573560 - Simplify the Form Assistant code in browser-ui.js

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Since bug 566288, the form helper part into browser-ui can be simplified a lot since this is only UI now.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Also, the SelectHelper opening part of bindings.xml which open the xul menulist can be cleanup.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: wip-0.1

Plan is to removed the FormWrapper class and the needs for BasicWrapper in bindings.xml.

The wip is not functionnal at all yet, it is just a big rewrite/removal to see what I want

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: wip v0.2

This one works better, but it still miss the UI for handling <select />

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

This is pretty final but there's probably some places where this can be cleaned up.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 454042 [details] [diff] [review]
Patch

Asking review  instead of feedback because some cleanups has been made into bug 573561.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch v0.2

This is updated on trunk and include some parts of bug 573561.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 457062 [details] [diff] [review]
Patch v0.2

I had to fix some bitrot and change gPrefService -> Services.prefs, but things seem to work ok.

Since I have the patch unbitrotted, I'll land it

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
http://hg.mozilla.org/mobile-browser/rev/1eb35d99a861

Vivien - I'll let you handle updating bug 573561 as needed