Closed Bug 573561 Opened 10 years ago Closed 10 years ago

Simplify the Form Assistant code in forms.js

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

Attachments

(1 file, 4 obsolete files)

Since bug 566288 has landed the code into forms.js can be simplified.
Attached patch wip-0.1 (obsolete) — Splinter Review
Non-functionnal wip, but this is basically what i want. This is based on bug 573560.
The patch does not include: 
 * a working version of forms.js
 * a replacement for the hack actuallly use into bindings.xml
Attached patch wip v0.2 (obsolete) — Splinter Review
The wip starts to work but it misses:
 * the "select" part.
 * The removal of the bindings.xml hack
 * getLabelsFor can probably be removed now with the html5 labels property (thanks volkmar!)
Attachment #454494 - Attachment is obsolete: true
Attached patch Patch (obsolete) — Splinter Review
This patch is based on bug 573560
Assignee: nobody → 21
Attachment #454563 - Attachment is obsolete: true
Attachment #454812 - Flags: review?(mark.finkle)
Attachment #454563 - Flags: review?(mark.finkle)
Attached patch Patch v0.2 (obsolete) — Splinter Review
This correct a minor bug with the keyup event
Attachment #454812 - Attachment is obsolete: true
Attachment #454812 - Flags: review?(mark.finkle)
Attached patch Patch v0.3Splinter Review
Patch is updated on trunk and include minors corrections for optgroup handling.
Attachment #454906 - Attachment is obsolete: true
Attachment #457095 - Flags: review?(mark.finkle)
Comment on attachment 457095 [details] [diff] [review]
Patch v0.3

There is a lot going on in this patch, but the end result is good
Attachment #457095 - Flags: review?(mark.finkle) → review+
http://hg.mozilla.org/mobile-browser/rev/54c8dc8dc01c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.