573582 - [mozmill] Failures in testSearch/testSearchSelection.js:testSearchSelectionViaContextMenu

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Error: Controller.assertJS("subject.URLContainsDomain == true")

Comment 1

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Seen in WinXP, Win7, Mac

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Geo, when you work on this bug please also move the external search to a local search. You can add the opensearch search from http://hg.mozilla.org/qa/litmus-data/file/tip/firefox/search to our repository and use that search engine. Further we will also need a local test page which some paragraphs like lorem ipsum.

Comment 3

[Aaron Train [:aaronmt]]

Was investing this test failure and it's due to some random occurrence where a new tab (about:blank) is opened up alongside the searching tab (in background). It becomes the activeTab and is then compared against in checkSearchResultPage. 

Recent test failure from 06/23/10:

http://brasstacks.mozilla.com/couchdb/mozmill/_design/reports/_show/report/63a483947eda11dfbd2f005056a533eb

Comment 4

[Aaron Train [:aaronmt]]

Still up there for 4.0b5 

http://brasstacks.mozilla.com/couchdb/mozmill/_design/reports/_show/report/d37f8f06049accd405a3f2b55dab3f3f

Comment 5

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (default)

So with 1.5.1 running the only test failure I see is the failure as identified in comment #0, and it is easier to fix at the moment. 

This test uses mozilla_mission as it's local-data file but searches online currently.

We are searching through selecting a word in a lengthy paragraph. With the coordinate clicking fix in bug 583604 that's on the 1.5.1 hot-fix branch, we are double clicking  in the centre of the paragraph which ends up selecting: 'tool's to', which in the search query URL, will be shown as: 'tools+to' and is failing checkSearchResultPage(); because of the whitespace -> + difference.

Work around is to either make checkSearchResultPage smarter, or just put in coordinates to pick a single word in the test. If I put the coordinates, 20, 10 in the doubleClick call, we search up 'Mozilla' which will work and pass the test.

For the moment, this patch will pass the test by using coordinates in the double click and select a single word.

Comment 6

[Aaron Train [:aaronmt]]

Testing this in 1.5.1, this also depends on bug 604832

Comment 7

[Aaron Train [:aaronmt]]

(In reply to comment #6)
> Testing this in 1.5.1, this also depends on bug 604832

The current patch in that bug with a change in testTabbedBrowsingAPI.js to selectedIndex which this test uses.

Comment 8

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (default) [coords 5,5]

Comment 9

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 484773 [details] [diff] [review]
Patch v1 - (default) [coords 5,5]

LGTM

Comment 10

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Landed on default as http://hg.mozilla.org/qa/mozmill-tests/rev/8e7eb4910116

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So you have decided against the usage of the selection API, as what we have discussed two days ago in the mozmill channel?

Comment 12

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

I'd have to check logs to get specifics, but Aaron said he was getting some sort of warning or error back using that API. We decided to go with the coordinates you suggested instead until we could investigate further.

I'm sure Aaron can amplify.

Comment 13

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (1.9.2/1.9.1) [coord 5,5]

This present fix in the interim is also required on older branches as it's as well a reoccurring failure shown on the dashboard. If it's ok, I have attached a patch good for both branches, and will flag for review once indicated by Geo.

Comment 14

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 487373 [details] [diff] [review]
Patch v1 - (1.9.2/1.9.1) [coord 5,5]

Looks fine, please land.

Comment 15

[Aaron Train [:aaronmt]]

The selection error I was getting was a NS_ERROR_DOM_SECURITY_ERROR when using
createRange to get my starting and ending offsets of text.   |var range =
controller.window.document.createRange();|

Comment 16

[Aaron Train [:aaronmt]]

http://hg.mozilla.org/qa/mozmill-tests/rev/e08b38125219  - 1.9.2
http://hg.mozilla.org/qa/mozmill-tests/rev/ac1a4b9dc91a - 1.9.1

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.