573612 - Component overrides do not work in omnijar

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Omnijar does not register components in a guaranteed order based on components.list, so components cannot reliably override contractIDs of other components.  This causes Fennec components like PromptService not to work on Android (originally reported as bug 573130).

Comment 1

[Michael Wu [:mwu]]

I'm going to wait for bsmedberg's rewrite of component loading before tackling this properly, assuming it'll even be necessary after that. In the meantime I'm going to do some stupid tricks with our packaging to make things work as expected.

Comment 2

[Justin Wood (:Callek)]

Matt/Mwu, is this WFM/INVALID/or NEW as of now (since ben's component loading changes have landed).

Comment 3

[Matt Brubeck (:mbrubeck)]

This is still reproducible with the new component registration code.

Comment 4

[Doug Turner (:dougt)]

bsmedberg, i heard that this bug will be fixed by your work on combined-manifests.

Comment 5

[Benjamin Smedberg]

Very likely. That's hung up on getting Talos fixed, but I think it should land next week.

Comment 6

[Michael Wu [:mwu]]

Fixed by bug 579178 AFAICT.