573622 - FlightDeck should point to version of helper addon hosted at AMO

Status: VERIFIED FIXED

(Mozilla Labs Graveyard :: FlightDeck, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

Once the helper addon is hosted at AMO (bug 573621), FlightDeck should point to the version of the addon hosted at AMO.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

The URL to which FlightDeck should point is the following:

https://addons.mozilla.org/firefox/downloads/latest/182410?src=external-builder

Comment 2

[Piotr Zalewa [:zalun]]

I will create a parameter in the settings of FlightDeck which will allow to set a different Addons Builder's XPI URL if needed.

Comment 3

[Piotr Zalewa [:zalun]]

I've added it to the FlightDeck
It is not working as flightdeck.zalewa.info is not on the allowed sites lists. I think http://127.0.0.1:8090 (default server to run the FD locally) should be in the allowed sites.

I will create a parameter in the settings of FlightDeck which will allow to set a different Addons Builder's XPI URL if needed.

Comment 4

[Piotr Zalewa [:zalun]]

http://github.com/zalun/FlightDeck/blob/master/flightdeck/settings.py#L89
This may be overwritten in flightdeck/setting_local.py

Comment 5

[Atul Varma [:atul]]

(In reply to comment #3)
> I've added it to the FlightDeck
> It is not working as flightdeck.zalewa.info is not on the allowed sites lists.
> I think http://127.0.0.1:8090 (default server to run the FD locally) should be
> in the allowed sites.

Hmm, good point... What if the addon also looked at a preference in firefox, say, extensions.addonBuilder.trustedDomains, and used that to append to the list of trusted domains? This would allow developers to go to about:config and enter that information, putting in whatever value(s) they want.

Comment 6

[Piotr Zalewa [:zalun]]

(In reply to comment #5)
> What if the addon also looked at a preference in firefox

Even better - it will remove the need to reinstall the Add on

Comment 7

[Atul Varma [:atul]]

Cool, I made bug 573790 to track this.

Comment 8

[Daniel Buchner [:dbuc]]

The staging box at https://lm-app-flightdeck-stage01.mozillalabs.com still is not serving the updated version of the Helper add-on when prompted to install it.

Comment 9

[Daniel Buchner [:dbuc]]

Further, there is no add-on installed at all, not even an older one. A page reload is all that occurs when clicking the link to install the add-on.

Comment 10

[Daniel Buchner [:dbuc]]

If you travel into the edit view of any add-on (I was in this particular one: https://lm-app-flightdeck-stage01.mozillalabs.com/addon/edit/1000109/latest/) and try to click "Test" without the Add-ons Builder Helper installed, you will get a notification box that drops down from above. When pressing the link in the drop-down titled "Please install FlightDeck Add-on" the page simply reloads without prompting to install the add-on.

Comment 11

[Myk Melez [:myk] [@mykmelez]]

I see the same problem Daniel is seeing, and it happens for me with the Test buttons on the home page as well.

Comment 12

[Piotr Zalewa [:zalun]]

I can't reproduce
It is displaying the warning, after I click on the link FF is asking me to allow installing add-ons from that site. After allowed - add-on was downloaded fine

Comment 13

[Myk Melez [:myk] [@mykmelez]]

Hmm, indeed, I see that too, now.  I wonder why it wasn't working before.