Add --disable-auto-deps to nightly mozconfigs

RESOLVED FIXED

Status

P5
normal
RESOLVED FIXED
9 years ago
7 months ago

People

(Reporter: catlee, Assigned: coop)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozconfig])

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
Spin-off from bug 573199.

For builds that are always full clobbers, like nightly builds and try builds, disabling auto deps has a significant speed win on windows.

We should figure out how to get our nightly builds building with this option.  Slightly complicated by the fact that the nightly builds share the same mozconfigs as the regular depend builds.
(Reporter)

Updated

9 years ago
Priority: -- → P5
catlee - is this still needed?
Whiteboard: [mozconfig]
cc'ing joey so he can give it a review
(In reply to Mike Taylor [:bear] from comment #1)
> catlee - is this still needed?

Doubtful that its *needed* but certainly helpful.

I bet even without the depend-nightly distinction in mozconfigs yet, this would help us in release mozconfigs. (if done there, be sure to add to the release whitelist)
(Reporter)

Comment 4

7 years ago
perhaps we could start by putting some indication in the environment that the build is a nightly build rather than a depend build?
(Assignee)

Updated

7 years ago
Assignee: nobody → coop
Component: Release Engineering → Release Engineering: Automation (General)
QA Contact: release → catlee
(Assignee)

Comment 5

7 years ago
Created attachment 624533 [details] [diff] [review]
Set IS_NIGHTLY for nightly builds
Attachment #624533 - Flags: review?(bear)

Updated

7 years ago
Attachment #624533 - Flags: review?(bear) → review+
(Assignee)

Comment 6

7 years ago
Created attachment 624541 [details] [diff] [review]
Set --disable-auto-deps for Windows nightlies

This patch checks for the ENV var set by the buildbotcustom patch in attachment 624533 [details] [diff] [review].
Attachment #624541 - Flags: review?(joey)
(Assignee)

Comment 7

7 years ago
Comment on attachment 624541 [details] [diff] [review]
Set --disable-auto-deps for Windows nightlies

https://hg.mozilla.org/build/buildbotcustom/rev/67b4eea6c895
Attachment #624541 - Flags: checked-in?
(Assignee)

Updated

7 years ago
Attachment #624541 - Flags: checked-in?
Comment on attachment 624541 [details] [diff] [review]
Set --disable-auto-deps for Windows nightlies

Review of attachment 624541 [details] [diff] [review]:
-----------------------------------------------------------------

## For known full-clobber builds on Windows

Are there any other variables available that could be used to test nightly & clobber ?
If nighties are able to support dependency builds later testing only $IS_NIGHTLY would always assume clobber.

Minor but I would indent ac_add_options as a visual cue that it belongs to the conditional.
Attachment #624541 - Flags: review?(joey) → review+
(Assignee)

Comment 10

7 years ago
Comment on attachment 624541 [details] [diff] [review]
Set --disable-auto-deps for Windows nightlies

https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=94c7c6648af7
Attachment #624541 - Flags: checked-in+
(Assignee)

Comment 11

7 years ago
Windows builds are green on inbound. This will ride the trains.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Component: General Automation → General
Product: Release Engineering → Release Engineering
You need to log in before you can comment on or make changes to this bug.